Fix WAITAOF test in external test due to appendonly is enabled (#775)

The test fails because, in external, another test may have
enabled appendonly, causing acklocal to return 1.

We can add a CONFIG SET to disable the appendonly, but this
is not safe too unless we use multi. The test does not actually
rely on appendonly, so we can just * it.

Fixes #770.

Signed-off-by: Binbin <binloveplay1314@qq.com>
This commit is contained in:
Binbin 2024-07-12 23:32:39 +08:00 committed by GitHub
parent 9948f07a01
commit a4ee8dada4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -293,10 +293,9 @@ start_server {tags {"scripting"}} {
run_script {return redis.pcall('wait','1','0')} 0
} {0}
# Temporarily disable test for external until it is stabilized, see https://github.com/valkey-io/valkey/issues/770
test {EVAL - Scripts do not block on waitaof} {
run_script {redis.call('incr', 'x') return redis.pcall('waitaof','0','1','0')} 0
} {0 0} {external:skip}
} {* 0}
test {EVAL - Scripts do not block on XREAD with BLOCK option} {
r del s