gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Fix timing issue in cluster-shards tests (#1243)

Browse Source 
The cluster-node-timeout is 3000 in our tests, the timing test wasn't
succeeding, so extending the wait_for made them much more reliable.

Signed-off-by: Binbin <binloveplay1314@qq.com>
This commit is contained in:
Binbin 2024-11-02 19:51:14 +08:00 committed by GitHub
parent 0d7b2344b2
commit a102852d5e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/cluster/tests/28-cluster-shards.tcl
View File

@ -117,7 +117,7 @@ test "Kill a node and tell the replica to immediately takeover" {
# Primary 0 node should report as fail, wait until the new primary acknowledges it. # Primary 0 node should report as fail, wait until the new primary acknowledges it.
test "Verify health as fail for killed node" { test "Verify health as fail for killed node" {
wait_for_condition 50 100 { wait_for_condition 1000 50 {
"fail" eq [dict get [get_node_info_from_shard $node_0_id 4 "node"] "health"] "fail" eq [dict get [get_node_info_from_shard $node_0_id 4 "node"] "health"]
} else { } else {
fail "New primary never detected the node failed" fail "New primary never detected the node failed"

2
tests/unit/cluster/cluster-shards.tcl
View File

@ -42,7 +42,7 @@ start_cluster 3 3 {tags {external:skip cluster}} {
} }
test "Verify health as fail for killed node" { test "Verify health as fail for killed node" {
wait_for_condition 50 100 { wait_for_condition 1000 50 {
"fail" eq [dict get [get_node_info_from_shard $node_0_id $validation_node "node"] "health"] "fail" eq [dict get [get_node_info_from_shard $node_0_id $validation_node "node"] "health"]
} else { } else {
fail "New primary never detected the node failed" fail "New primary never detected the node failed"