gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove an unnecessary lock that eats performance

Browse Source 
Former-commit-id: 8eb4e355b934e394608b082c7d1973152238fa1f
This commit is contained in:
John Sully 2019-06-16 00:16:36 -04:00
parent 049ca9bf58
commit 9a050ffb42
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/networking.cpp
View File

@ -1685,9 +1685,12 @@ int handleClientsWithPendingWrites(int iel) {
} }
} }
AeLocker locker; if (listLength(serverTL->clients_pending_asyncwrite))
locker.arm(nullptr); {
ProcessPendingAsyncWrites(); AeLocker locker;
locker.arm(nullptr);
ProcessPendingAsyncWrites();
}
return processed; return processed;
} }
@ -2205,8 +2208,11 @@ void readQueryFromClient(aeEventLoop *el, int fd, void *privdata, int mask) {
* corresponding part of the replication stream, will be propagated to * corresponding part of the replication stream, will be propagated to
* the sub-slaves and to the replication backlog. */ * the sub-slaves and to the replication backlog. */
processInputBufferAndReplicate(c); processInputBufferAndReplicate(c);
aelock.arm(c); if (listLength(serverTL->clients_pending_asyncwrite))
ProcessPendingAsyncWrites(); {
aelock.arm(c);
ProcessPendingAsyncWrites();
}
} }
void getClientsMaxBuffers(unsigned long *longest_output_list, void getClientsMaxBuffers(unsigned long *longest_output_list,