From 9956f4f61b5698ee4cc9e83e4775bc625fed3181 Mon Sep 17 00:00:00 2001 From: antirez Date: Mon, 19 Nov 2018 17:00:30 +0100 Subject: [PATCH] Stream: fix XREADGROUP history reading of deleted messages. This commit fixes #5570. It is a similar bug to one fixed a few weeks ago and is due to the range API to be called with NULL as "end ID" parameter instead of repeating again the start ID, to be sure that we selectively issue the entry with a given ID, or we get zero returned (and we know we should emit a NULL reply). --- src/t_stream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/t_stream.c b/src/t_stream.c index dd83f2b1d..f51f6c46b 100644 --- a/src/t_stream.c +++ b/src/t_stream.c @@ -1025,7 +1025,7 @@ size_t streamReplyWithRangeFromConsumerPEL(client *c, stream *s, streamID *start if (end && memcmp(ri.key,end,ri.key_len) > 0) break; streamID thisid; streamDecodeID(ri.key,&thisid); - if (streamReplyWithRange(c,s,&thisid,NULL,1,0,NULL,NULL, + if (streamReplyWithRange(c,s,&thisid,&thisid,1,0,NULL,NULL, STREAM_RWR_RAWENTRIES,NULL) == 0) { /* Note that we may have a not acknowledged entry in the PEL