From 9012e587ca6f7c7ef54e86a782910625fe3dc3e9 Mon Sep 17 00:00:00 2001
From: "zhaozhao.zz" <zhaozhao.zz@alibaba-inc.com>
Date: Tue, 23 Jul 2019 15:25:00 +0800
Subject: [PATCH] Client side caching: do not reclaim tracking table if it's
 empty

---
 src/tracking.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/tracking.c b/src/tracking.c
index 1189e82d5..badec69a7 100644
--- a/src/tracking.c
+++ b/src/tracking.c
@@ -206,8 +206,6 @@ void trackingInvalidateKey(robj *keyobj) {
  * flush the table: it will slowly get garbage collected as more keys
  * are modified in the used caching slots. */
 void trackingInvalidateKeysOnFlush(int dbid) {
-    UNUSED(dbid);
-
     if (server.tracking_clients) {
         listNode *ln;
         listIter li;
@@ -222,12 +220,11 @@ void trackingInvalidateKeysOnFlush(int dbid) {
 
     /* In case of FLUSHALL, reclaim all the memory used by tracking. */
     if (dbid == -1 && TrackingTable) {
-        for (int j = 0; j < TRACKING_TABLE_SIZE; j++) {
+        for (int j = 0; j < TRACKING_TABLE_SIZE && TrackingTableUsedSlots > 0; j++) {
             if (TrackingTable[j] != NULL) {
                 raxFree(TrackingTable[j]);
                 TrackingTable[j] = NULL;
                 TrackingTableUsedSlots--;
-                if (TrackingTableUsedSlots == 0) break;
             }
         }