gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fixed Tracking test “The other connection is able to get invalidations” (#7871)

Browse Source 
PROBLEM:

[$rd1 read] reads invalidation messages one by one, so it's never going to see the second invalidation message produced after INCR b, whether or not it exists. Adding another read will block incase no invalidation message is produced.

FIX:

We switch the order of "INCR a" and "INCR b" - now "INCR b" comes first. We still only read the first invalidation message produces. If an invalidation message is wrongly produces for b - then it will be produced before that of a, since "INCR b" comes before "INCR a".

Co-authored-by: Nitai Caro <caronita@amazon.com>
This commit is contained in:
nitaicaro 2020-09-30 19:52:01 +03:00 committed by GitHub
parent 67b43f75e2
commit 8fb89a5728
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/unit/tracking.tcl
View File

@ -16,9 +16,10 @@ start_server {tags {"tracking"}} {
test {The other connection is able to get invalidations} { test {The other connection is able to get invalidations} {
r SET a 1 r SET a 1
r SET b 1
r GET a r GET a
r INCR a
r INCR b ; # This key should not be notified, since it wasn't fetched. r INCR b ; # This key should not be notified, since it wasn't fetched.
r INCR a
set keys [lindex [$rd1 read] 2] set keys [lindex [$rd1 read] 2]
assert {[llength $keys] == 1} assert {[llength $keys] == 1}
assert {[lindex $keys 0] eq {a}} assert {[lindex $keys 0] eq {a}}