From 8cccc6b468f4b134964d4500c44486db681311cb Mon Sep 17 00:00:00 2001 From: antirez Date: Wed, 23 Oct 2019 10:52:25 +0200 Subject: [PATCH] Modules hooks: don't call the hook for fake clients. --- src/networking.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/networking.c b/src/networking.c index dec49642f..e7cc561fa 100644 --- a/src/networking.c +++ b/src/networking.c @@ -1043,9 +1043,13 @@ void freeClient(client *c) { freeClientAsync(c); return; } - moduleFireServerEvent(REDISMODULE_EVENT_CLIENT_CHANGE, - REDISMODULE_SUBEVENT_CLIENT_CHANGE_DISCONNECTED, - c); + + /* For connected clients, call the disconnection event of modules hooks. */ + if (c->conn) { + moduleFireServerEvent(REDISMODULE_EVENT_CLIENT_CHANGE, + REDISMODULE_SUBEVENT_CLIENT_CHANGE_DISCONNECTED, + c); + } /* If it is our master that's beging disconnected we should make sure * to cache the state to try a partial resynchronization later.