From 888e92eb5797c1a6ce4c7b89c5814dbe13a8d8e3 Mon Sep 17 00:00:00 2001 From: sundb Date: Sat, 1 Jan 2022 23:45:13 +0800 Subject: [PATCH] Fix a valgrind test failure due to slowly shutdown (#10038) This pr is mainly to solve the problem that redis process cannot be exited normally, due to changes in #10003. When a test uses the `key-load-delay` config to delay loading, but does not reset it at the end of the test, will lead to server wait for the loading to reach the event loop (once in 2mb) before actually shutting down. --- tests/integration/replication.tcl | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/integration/replication.tcl b/tests/integration/replication.tcl index c721d5c4c..5755d3a3e 100644 --- a/tests/integration/replication.tcl +++ b/tests/integration/replication.tcl @@ -944,6 +944,7 @@ test "diskless replication child being killed is collected" { set loglines [count_log_lines 0] $replica config set repl-diskless-load swapdb $replica config set key-load-delay 1000000 + $replica config set loading-process-events-interval-bytes 1024 $replica replicaof $master_host $master_port # wait for the replicas to start reading the rdb @@ -962,6 +963,9 @@ test "diskless replication child being killed is collected" { } else { fail "rdb child didn't terminate" } + + # Speed up shutdown + $replica config set key-load-delay 0 } } } {} {external:skip}