moduleRDBLoadError, add key name, and use panic rather than exit

using panic rather than exit means you get s stack trace of the code
path that experianced the error, and possibly other info.
This commit is contained in:
Oran Agra 2020-02-06 09:37:04 +02:00
parent 44ac202fbf
commit 85cc696f50

View File

@ -3649,14 +3649,15 @@ void moduleRDBLoadError(RedisModuleIO *io) {
io->error = 1; io->error = 1;
return; return;
} }
serverLog(LL_WARNING, serverPanic(
"Error loading data from RDB (short read or EOF). " "Error loading data from RDB (short read or EOF). "
"Read performed by module '%s' about type '%s' " "Read performed by module '%s' about type '%s' "
"after reading '%llu' bytes of a value.", "after reading '%llu' bytes of a value "
"for key named: '%s'.",
io->type->module->name, io->type->module->name,
io->type->name, io->type->name,
(unsigned long long)io->bytes); (unsigned long long)io->bytes,
exit(1); io->key? (char*)io->key->ptr: "(null)");
} }
/* Returns 0 if there's at least one registered data type that did not declare /* Returns 0 if there's at least one registered data type that did not declare