diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 43547a431..a38f9ab32 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -11,7 +11,7 @@ jobs: - name: make # Fail build if there are warnings # build with TLS just for compilation coverage - run: make REDIS_CFLAGS='-Werror' BUILD_TLS=yes + run: make SERVER_CFLAGS='-Werror' BUILD_TLS=yes - name: test run: | sudo apt-get install tcl8.6 tclx @@ -31,7 +31,7 @@ jobs: - uses: actions/checkout@v3 - name: make # build with TLS module just for compilation coverage - run: make SANITIZER=address REDIS_CFLAGS='-Werror' BUILD_TLS=module + run: make SANITIZER=address SERVER_CFLAGS='-Werror' BUILD_TLS=module - name: testprep run: sudo apt-get install tcl8.6 tclx -y - name: test @@ -47,14 +47,14 @@ jobs: - name: make run: | apt-get update && apt-get install -y build-essential - make REDIS_CFLAGS='-Werror' + make SERVER_CFLAGS='-Werror' build-macos-latest: runs-on: macos-latest steps: - uses: actions/checkout@v3 - name: make - run: make REDIS_CFLAGS='-Werror' + run: make SERVER_CFLAGS='-Werror' build-32bit: runs-on: ubuntu-latest @@ -63,14 +63,14 @@ jobs: - name: make run: | sudo apt-get update && sudo apt-get install libc6-dev-i386 - make REDIS_CFLAGS='-Werror' 32bit + make SERVER_CFLAGS='-Werror' 32bit build-libc-malloc: runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 - name: make - run: make REDIS_CFLAGS='-Werror' MALLOC=libc + run: make SERVER_CFLAGS='-Werror' MALLOC=libc build-centos7-jemalloc: runs-on: ubuntu-latest @@ -80,5 +80,5 @@ jobs: - name: make run: | yum -y install gcc make - make REDIS_CFLAGS='-Werror' + make SERVER_CFLAGS='-Werror' diff --git a/.github/workflows/daily.yml b/.github/workflows/daily.yml index 72720e6dd..83ccb6a3c 100644 --- a/.github/workflows/daily.yml +++ b/.github/workflows/daily.yml @@ -23,7 +23,7 @@ on: default: '' use_repo: description: 'repo owner and name' - default: 'redis/redis' + default: 'valkey-io/valkey' use_git_ref: description: 'git branch or sha to use' default: 'unstable' @@ -34,7 +34,7 @@ jobs: test-ubuntu-jemalloc: runs-on: ubuntu-latest if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'ubuntu') timeout-minutes: 14400 steps: @@ -52,7 +52,7 @@ jobs: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} - name: make - run: make REDIS_CFLAGS='-Werror -DREDIS_TEST' + run: make SERVER_CFLAGS='-Werror -DREDIS_TEST' - name: testprep run: sudo apt-get install tcl8.6 tclx - name: test @@ -69,12 +69,12 @@ jobs: run: ./runtest-cluster ${{github.event.inputs.cluster_test_args}} - name: unittest if: true && !contains(github.event.inputs.skiptests, 'unittest') - run: ./src/redis-server test all --accurate + run: ./src/valkey-server test all --accurate test-ubuntu-jemalloc-fortify: runs-on: ubuntu-latest if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'fortify') container: ubuntu:lunar timeout-minutes: 14400 @@ -96,7 +96,7 @@ jobs: run: | apt-get update && apt-get install -y make gcc-13 update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-13 100 - make CC=gcc REDIS_CFLAGS='-Werror -DREDIS_TEST -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3' + make CC=gcc SERVER_CFLAGS='-Werror -DREDIS_TEST -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3' - name: testprep run: apt-get install -y tcl8.6 tclx procps - name: test @@ -113,12 +113,12 @@ jobs: run: ./runtest-cluster ${{github.event.inputs.cluster_test_args}} - name: unittest if: true && !contains(github.event.inputs.skiptests, 'unittest') - run: ./src/redis-server test all --accurate + run: ./src/valkey-server test all --accurate test-ubuntu-libc-malloc: runs-on: ubuntu-latest if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'malloc') timeout-minutes: 14400 steps: @@ -136,7 +136,7 @@ jobs: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} - name: make - run: make MALLOC=libc REDIS_CFLAGS='-Werror' + run: make MALLOC=libc SERVER_CFLAGS='-Werror' - name: testprep run: sudo apt-get install tcl8.6 tclx - name: test @@ -155,7 +155,7 @@ jobs: test-ubuntu-no-malloc-usable-size: runs-on: ubuntu-latest if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'malloc') timeout-minutes: 14400 steps: @@ -173,7 +173,7 @@ jobs: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} - name: make - run: make MALLOC=libc CFLAGS=-DNO_MALLOC_USABLE_SIZE REDIS_CFLAGS='-Werror' + run: make MALLOC=libc CFLAGS=-DNO_MALLOC_USABLE_SIZE SERVER_CFLAGS='-Werror' - name: testprep run: sudo apt-get install tcl8.6 tclx - name: test @@ -192,7 +192,7 @@ jobs: test-ubuntu-32bit: runs-on: ubuntu-latest if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, '32bit') timeout-minutes: 14400 steps: @@ -212,7 +212,7 @@ jobs: - name: make run: | sudo apt-get update && sudo apt-get install libc6-dev-i386 - make 32bit REDIS_CFLAGS='-Werror -DREDIS_TEST' + make 32bit SERVER_CFLAGS='-Werror -DREDIS_TEST' - name: testprep run: sudo apt-get install tcl8.6 tclx - name: test @@ -231,12 +231,12 @@ jobs: run: ./runtest-cluster ${{github.event.inputs.cluster_test_args}} - name: unittest if: true && !contains(github.event.inputs.skiptests, 'unittest') - run: ./src/redis-server test all --accurate + run: ./src/valkey-server test all --accurate test-ubuntu-tls: runs-on: ubuntu-latest if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'tls') timeout-minutes: 14400 steps: @@ -255,7 +255,7 @@ jobs: ref: ${{ env.GITHUB_HEAD_REF }} - name: make run: | - make BUILD_TLS=yes REDIS_CFLAGS='-Werror' + make BUILD_TLS=yes SERVER_CFLAGS='-Werror' - name: testprep run: | sudo apt-get install tcl8.6 tclx tcl-tls @@ -280,7 +280,7 @@ jobs: test-ubuntu-tls-no-tls: runs-on: ubuntu-latest if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'tls') timeout-minutes: 14400 steps: @@ -299,7 +299,7 @@ jobs: ref: ${{ env.GITHUB_HEAD_REF }} - name: make run: | - make BUILD_TLS=yes REDIS_CFLAGS='-Werror' + make BUILD_TLS=yes SERVER_CFLAGS='-Werror' - name: testprep run: | sudo apt-get install tcl8.6 tclx tcl-tls @@ -324,7 +324,7 @@ jobs: test-ubuntu-io-threads: runs-on: ubuntu-latest if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'iothreads') timeout-minutes: 14400 steps: @@ -343,7 +343,7 @@ jobs: ref: ${{ env.GITHUB_HEAD_REF }} - name: make run: | - make REDIS_CFLAGS='-Werror' + make SERVER_CFLAGS='-Werror' - name: testprep run: sudo apt-get install tcl8.6 tclx - name: test @@ -356,7 +356,7 @@ jobs: test-ubuntu-reclaim-cache: runs-on: ubuntu-latest if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'specific') timeout-minutes: 14400 steps: @@ -375,7 +375,7 @@ jobs: ref: ${{ env.GITHUB_HEAD_REF }} - name: make run: | - make REDIS_CFLAGS='-Werror' + make SERVER_CFLAGS='-Werror' - name: testprep run: | sudo apt-get install vmtouch @@ -383,19 +383,19 @@ jobs: mkdir /tmp/slave - name: warm up run: | - ./src/redis-server --daemonize yes --logfile /dev/null - ./src/redis-benchmark -n 1 > /dev/null - ./src/redis-cli save | grep OK > /dev/null + ./src/valkey-server --daemonize yes --logfile /dev/null + ./src/valkey-benchmark -n 1 > /dev/null + ./src/valkey-cli save | grep OK > /dev/null vmtouch -v ./dump.rdb > /dev/null - name: test run: | echo "test SAVE doesn't increase cache" CACHE0=$(grep -w file /sys/fs/cgroup/memory.stat | awk '{print $2}') echo "$CACHE0" - ./src/redis-server --daemonize yes --logfile /dev/null --dir /tmp/master --port 8080 --repl-diskless-sync no --pidfile /tmp/master/redis.pid --rdbcompression no --enable-debug-command yes - ./src/redis-cli -p 8080 debug populate 10000 k 102400 - ./src/redis-server --daemonize yes --logfile /dev/null --dir /tmp/slave --port 8081 --repl-diskless-load disabled --rdbcompression no - ./src/redis-cli -p 8080 save > /dev/null + ./src/valkey-server --daemonize yes --logfile /dev/null --dir /tmp/master --port 8080 --repl-diskless-sync no --pidfile /tmp/master/redis.pid --rdbcompression no --enable-debug-command yes + ./src/valkey-cli -p 8080 debug populate 10000 k 102400 + ./src/valkey-server --daemonize yes --logfile /dev/null --dir /tmp/slave --port 8081 --repl-diskless-load disabled --rdbcompression no + ./src/valkey-cli -p 8080 save > /dev/null VMOUT=$(vmtouch -v /tmp/master/dump.rdb) echo $VMOUT grep -q " 0%" <<< $VMOUT @@ -404,8 +404,8 @@ jobs: if [ "$(( $CACHE-$CACHE0 ))" -gt "8000000" ]; then exit 1; fi echo "test replication doesn't increase cache" - ./src/redis-cli -p 8081 REPLICAOF 127.0.0.1 8080 > /dev/null - while [ $(./src/redis-cli -p 8081 info replication | grep "master_link_status:down") ]; do sleep 1; done; + ./src/valkey-cli -p 8081 REPLICAOF 127.0.0.1 8080 > /dev/null + while [ $(./src/valkey-cli -p 8081 info replication | grep "master_link_status:down") ]; do sleep 1; done; sleep 1 # wait for the completion of cache reclaim bio VMOUT=$(vmtouch -v /tmp/master/dump.rdb) echo $VMOUT @@ -421,8 +421,8 @@ jobs: PID=$(cat /tmp/master/redis.pid) kill -15 $PID while [ -x /proc/${PID} ]; do sleep 1; done - ./src/redis-server --daemonize yes --logfile /dev/null --dir /tmp/master --port 8080 - while [ $(./src/redis-cli -p 8080 info persistence | grep "loading:1") ]; do sleep 1; done; + ./src/valkey-server --daemonize yes --logfile /dev/null --dir /tmp/master --port 8080 + while [ $(./src/valkey-cli -p 8080 info persistence | grep "loading:1") ]; do sleep 1; done; sleep 1 # wait for the completion of cache reclaim bio VMOUT=$(vmtouch -v /tmp/master/dump.rdb) echo $VMOUT @@ -434,7 +434,7 @@ jobs: test-valgrind-test: runs-on: ubuntu-latest if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'valgrind') && !contains(github.event.inputs.skiptests, 'redis') timeout-minutes: 14400 steps: @@ -452,7 +452,7 @@ jobs: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} - name: make - run: make valgrind REDIS_CFLAGS='-Werror -DREDIS_TEST' + run: make valgrind SERVER_CFLAGS='-Werror -DREDIS_TEST' - name: testprep run: | sudo apt-get update @@ -464,7 +464,7 @@ jobs: test-valgrind-misc: runs-on: ubuntu-latest if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'valgrind') && !(contains(github.event.inputs.skiptests, 'modules') && contains(github.event.inputs.skiptests, 'unittest')) timeout-minutes: 14400 steps: @@ -482,7 +482,7 @@ jobs: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} - name: make - run: make valgrind REDIS_CFLAGS='-Werror -DREDIS_TEST' + run: make valgrind SERVER_CFLAGS='-Werror -DREDIS_TEST' - name: testprep run: | sudo apt-get update @@ -493,13 +493,13 @@ jobs: - name: unittest if: true && !contains(github.event.inputs.skiptests, 'unittest') run: | - valgrind --track-origins=yes --suppressions=./src/valgrind.sup --show-reachable=no --show-possibly-lost=no --leak-check=full --log-file=err.txt ./src/redis-server test all --valgrind + valgrind --track-origins=yes --suppressions=./src/valgrind.sup --show-reachable=no --show-possibly-lost=no --leak-check=full --log-file=err.txt ./src/valkey-server test all --valgrind if grep -q 0x err.txt; then cat err.txt; exit 1; fi test-valgrind-no-malloc-usable-size-test: runs-on: ubuntu-latest if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'valgrind') && !contains(github.event.inputs.skiptests, 'redis') timeout-minutes: 14400 steps: @@ -517,7 +517,7 @@ jobs: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} - name: make - run: make valgrind CFLAGS="-DNO_MALLOC_USABLE_SIZE -DREDIS_TEST" REDIS_CFLAGS='-Werror' + run: make valgrind CFLAGS="-DNO_MALLOC_USABLE_SIZE -DREDIS_TEST" SERVER_CFLAGS='-Werror' - name: testprep run: | sudo apt-get update @@ -529,7 +529,7 @@ jobs: test-valgrind-no-malloc-usable-size-misc: runs-on: ubuntu-latest if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'valgrind') && !(contains(github.event.inputs.skiptests, 'modules') && contains(github.event.inputs.skiptests, 'unittest')) timeout-minutes: 14400 steps: @@ -547,7 +547,7 @@ jobs: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} - name: make - run: make valgrind CFLAGS="-DNO_MALLOC_USABLE_SIZE -DREDIS_TEST" REDIS_CFLAGS='-Werror' + run: make valgrind CFLAGS="-DNO_MALLOC_USABLE_SIZE -DREDIS_TEST" SERVER_CFLAGS='-Werror' - name: testprep run: | sudo apt-get update @@ -558,13 +558,13 @@ jobs: - name: unittest if: true && !contains(github.event.inputs.skiptests, 'unittest') run: | - valgrind --track-origins=yes --suppressions=./src/valgrind.sup --show-reachable=no --show-possibly-lost=no --leak-check=full --log-file=err.txt ./src/redis-server test all --valgrind + valgrind --track-origins=yes --suppressions=./src/valgrind.sup --show-reachable=no --show-possibly-lost=no --leak-check=full --log-file=err.txt ./src/valkey-server test all --valgrind if grep -q 0x err.txt; then cat err.txt; exit 1; fi test-sanitizer-address: runs-on: ubuntu-latest if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'sanitizer') timeout-minutes: 14400 strategy: @@ -587,7 +587,7 @@ jobs: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} - name: make - run: make SANITIZER=address REDIS_CFLAGS='-DREDIS_TEST -Werror' + run: make SANITIZER=address SERVER_CFLAGS='-DREDIS_TEST -Werror' - name: testprep run: | sudo apt-get update @@ -606,12 +606,12 @@ jobs: run: ./runtest-cluster ${{github.event.inputs.cluster_test_args}} - name: unittest if: true && !contains(github.event.inputs.skiptests, 'unittest') - run: ./src/redis-server test all + run: ./src/valkey-server test all test-sanitizer-undefined: runs-on: ubuntu-latest if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'sanitizer') timeout-minutes: 14400 strategy: @@ -634,7 +634,7 @@ jobs: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} - name: make - run: make SANITIZER=undefined REDIS_CFLAGS='-DREDIS_TEST -Werror' LUA_DEBUG=yes # we (ab)use this flow to also check Lua C API violations + run: make SANITIZER=undefined SERVER_CFLAGS='-DREDIS_TEST -Werror' LUA_DEBUG=yes # we (ab)use this flow to also check Lua C API violations - name: testprep run: | sudo apt-get update @@ -653,12 +653,12 @@ jobs: run: ./runtest-cluster ${{github.event.inputs.cluster_test_args}} - name: unittest if: true && !contains(github.event.inputs.skiptests, 'unittest') - run: ./src/redis-server test all --accurate + run: ./src/valkey-server test all --accurate test-centos7-jemalloc: runs-on: ubuntu-latest if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'centos') container: centos:7 timeout-minutes: 14400 @@ -679,7 +679,7 @@ jobs: - name: make run: | yum -y install gcc make - make REDIS_CFLAGS='-Werror' + make SERVER_CFLAGS='-Werror' - name: testprep run: yum -y install which tcl tclx - name: test @@ -698,7 +698,7 @@ jobs: test-centos7-tls-module: runs-on: ubuntu-latest if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'tls') container: centos:7 timeout-minutes: 14400 @@ -720,7 +720,7 @@ jobs: run: | yum -y install centos-release-scl epel-release yum -y install devtoolset-7 openssl-devel openssl - scl enable devtoolset-7 "make BUILD_TLS=module REDIS_CFLAGS='-Werror'" + scl enable devtoolset-7 "make BUILD_TLS=module SERVER_CFLAGS='-Werror'" - name: testprep run: | yum -y install tcl tcltls tclx @@ -745,7 +745,7 @@ jobs: test-centos7-tls-module-no-tls: runs-on: ubuntu-latest if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'tls') container: centos:7 timeout-minutes: 14400 @@ -767,7 +767,7 @@ jobs: run: | yum -y install centos-release-scl epel-release yum -y install devtoolset-7 openssl-devel openssl - scl enable devtoolset-7 "make BUILD_TLS=module REDIS_CFLAGS='-Werror'" + scl enable devtoolset-7 "make BUILD_TLS=module SERVER_CFLAGS='-Werror'" - name: testprep run: | yum -y install tcl tcltls tclx @@ -792,7 +792,7 @@ jobs: test-macos-latest: runs-on: macos-latest if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'macos') && !(contains(github.event.inputs.skiptests, 'redis') && contains(github.event.inputs.skiptests, 'modules')) timeout-minutes: 14400 steps: @@ -810,7 +810,7 @@ jobs: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} - name: make - run: make REDIS_CFLAGS='-Werror' + run: make SERVER_CFLAGS='-Werror' - name: test if: true && !contains(github.event.inputs.skiptests, 'redis') run: ./runtest --accurate --verbose --verbose --clients 1 --no-latency --dump-logs ${{github.event.inputs.test_args}} @@ -821,7 +821,7 @@ jobs: test-macos-latest-sentinel: runs-on: macos-latest if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'macos') && !contains(github.event.inputs.skiptests, 'sentinel') timeout-minutes: 14400 steps: @@ -839,7 +839,7 @@ jobs: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} - name: make - run: make REDIS_CFLAGS='-Werror' + run: make SERVER_CFLAGS='-Werror' - name: sentinel tests if: true && !contains(github.event.inputs.skiptests, 'sentinel') run: ./runtest-sentinel ${{github.event.inputs.cluster_test_args}} @@ -847,7 +847,7 @@ jobs: test-macos-latest-cluster: runs-on: macos-latest if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'macos') && !contains(github.event.inputs.skiptests, 'cluster') timeout-minutes: 14400 steps: @@ -865,7 +865,7 @@ jobs: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} - name: make - run: make REDIS_CFLAGS='-Werror' + run: make SERVER_CFLAGS='-Werror' - name: cluster tests if: true && !contains(github.event.inputs.skiptests, 'cluster') run: ./runtest-cluster ${{github.event.inputs.cluster_test_args}} @@ -873,7 +873,7 @@ jobs: test-freebsd: runs-on: macos-12 if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'freebsd') && !(contains(github.event.inputs.skiptests, 'redis') && contains(github.event.inputs.skiptests, 'modules')) timeout-minutes: 14400 steps: @@ -905,7 +905,7 @@ jobs: test-freebsd-sentinel: runs-on: macos-12 if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'freebsd') && !contains(github.event.inputs.skiptests, 'sentinel') timeout-minutes: 14400 steps: @@ -936,7 +936,7 @@ jobs: test-freebsd-cluster: runs-on: macos-12 if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'freebsd') && !contains(github.event.inputs.skiptests, 'cluster') timeout-minutes: 14400 steps: @@ -967,7 +967,7 @@ jobs: test-alpine-jemalloc: runs-on: ubuntu-latest if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'alpine') container: alpine:latest steps: @@ -987,7 +987,7 @@ jobs: - name: make run: | apk add build-base - make REDIS_CFLAGS='-Werror' + make SERVER_CFLAGS='-Werror' - name: testprep run: apk add tcl procps tclx - name: test @@ -1006,7 +1006,7 @@ jobs: test-alpine-libc-malloc: runs-on: ubuntu-latest if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'alpine') container: alpine:latest steps: @@ -1026,7 +1026,7 @@ jobs: - name: make run: | apk add build-base - make REDIS_CFLAGS='-Werror' USE_JEMALLOC=no CFLAGS=-DUSE_MALLOC_USABLE_SIZE + make SERVER_CFLAGS='-Werror' USE_JEMALLOC=no CFLAGS=-DUSE_MALLOC_USABLE_SIZE - name: testprep run: apk add tcl procps tclx - name: test @@ -1046,7 +1046,7 @@ jobs: runs-on: ubuntu-latest timeout-minutes: 14400 if: | - (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) && + (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey')) && !contains(github.event.inputs.skipjobs, 'reply-schema') steps: - name: prep @@ -1063,7 +1063,7 @@ jobs: repository: ${{ env.GITHUB_REPOSITORY }} ref: ${{ env.GITHUB_HEAD_REF }} - name: make - run: make REDIS_CFLAGS='-Werror -DLOG_REQ_RES' + run: make SERVER_CFLAGS='-Werror -DLOG_REQ_RES' - name: testprep run: sudo apt-get install tcl8.6 tclx - name: test diff --git a/.github/workflows/external.yml b/.github/workflows/external.yml index 15a9afb6e..a18cf0908 100644 --- a/.github/workflows/external.yml +++ b/.github/workflows/external.yml @@ -1,82 +1,85 @@ name: External Server Tests on: - pull_request: - push: - schedule: - - cron: '0 0 * * *' + pull_request: + push: + schedule: + - cron: '0 0 * * *' jobs: test-external-standalone: runs-on: ubuntu-latest - if: github.event_name != 'schedule' || github.repository == 'redis/redis' + if: github.event_name != 'schedule' || github.repository == 'valkey-io/valkey' timeout-minutes: 14400 steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Build - run: make REDIS_CFLAGS=-Werror - - name: Start redis-server + run: make SERVER_CFLAGS=-Werror + - name: Start valkey-server run: | - ./src/redis-server --daemonize yes --save "" --logfile external-redis.log \ + ./src/valkey-server --daemonize yes --save "" --logfile external-server.log \ --enable-protected-configs yes --enable-debug-command yes --enable-module-command yes - name: Run external test run: | ./runtest \ --host 127.0.0.1 --port 6379 \ + --verbose \ --tags -slow - - name: Archive redis log + - name: Archive server log if: ${{ failure() }} uses: actions/upload-artifact@v3 with: - name: test-external-redis-log - path: external-redis.log + name: test-external-server-log + path: external-server.log test-external-cluster: runs-on: ubuntu-latest - if: github.event_name != 'schedule' || github.repository == 'redis/redis' + if: github.event_name != 'schedule' || github.repository == 'valkey-io/valkey' timeout-minutes: 14400 steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Build - run: make REDIS_CFLAGS=-Werror - - name: Start redis-server + run: make SERVER_CFLAGS=-Werror + - name: Start valkey-server run: | - ./src/redis-server --cluster-enabled yes --daemonize yes --save "" --logfile external-redis.log \ + ./src/valkey-server --cluster-enabled yes --daemonize yes --save "" --logfile external-server.log \ --enable-protected-configs yes --enable-debug-command yes --enable-module-command yes - name: Create a single node cluster - run: ./src/redis-cli cluster addslots $(for slot in {0..16383}; do echo $slot; done); sleep 5 + run: ./src/valkey-cli cluster addslots $(for slot in {0..16383}; do echo $slot; done); sleep 5 - name: Run external test run: | ./runtest \ --host 127.0.0.1 --port 6379 \ + --verbose \ --cluster-mode \ --tags -slow - - name: Archive redis log + - name: Archive server log if: ${{ failure() }} uses: actions/upload-artifact@v3 with: name: test-external-cluster-log - path: external-redis.log + path: external-server.log test-external-nodebug: runs-on: ubuntu-latest - if: github.event_name != 'schedule' || github.repository == 'redis/redis' + if: github.event_name != 'schedule' || github.repository == 'valkey-io/valkey' timeout-minutes: 14400 steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Build - run: make REDIS_CFLAGS=-Werror - - name: Start redis-server + run: make SERVER_CFLAGS=-Werror + - name: Start valkey-server run: | - ./src/redis-server --daemonize yes --save "" --logfile external-redis.log + ./src/valkey-server --daemonize yes --save "" --logfile external-server.log - name: Run external test run: | ./runtest \ --host 127.0.0.1 --port 6379 \ + --verbose \ --tags "-slow -needs:debug" - - name: Archive redis log + - name: Archive server log if: ${{ failure() }} uses: actions/upload-artifact@v3 with: - name: test-external-redis-log - path: external-redis.log + name: test-external-server-log + path: external-server.log \ No newline at end of file diff --git a/.gitignore b/.gitignore index 5ed94f1da..c9ea5d33c 100644 --- a/.gitignore +++ b/.gitignore @@ -5,13 +5,13 @@ *.d *.log dump.rdb -redis-benchmark -redis-check-aof -redis-check-rdb -redis-check-dump -redis-cli -redis-sentinel -redis-server +*-benchmark +*-check-aof +*-check-rdb +*-check-dump +*-cli +*-sentinel +*-server doc-tools release misc/* diff --git a/src/Makefile b/src/Makefile index ecbd2753d..280d63097 100644 --- a/src/Makefile +++ b/src/Makefile @@ -6,8 +6,8 @@ # what is needed for Redis plus the standard CFLAGS and LDFLAGS passed. # However when building the dependencies (Jemalloc, Lua, Hiredis, ...) # CFLAGS and LDFLAGS are propagated to the dependencies, so to pass -# flags only to be used when compiling / linking Redis itself REDIS_CFLAGS -# and REDIS_LDFLAGS are used instead (this is the case of 'make gcov'). +# flags only to be used when compiling / linking Redis itself SERVER_CFLAGS +# and SERVER_LDFLAGS are used instead (this is the case of 'make gcov'). # # Dependencies are stored in the Makefile.dep file. To rebuild this file # Just use 'make dep', but this is only needed by developers. @@ -19,11 +19,11 @@ CLANG := $(findstring clang,$(shell sh -c '$(CC) --version | head -1')) OPTIMIZATION?=-O3 ifeq ($(OPTIMIZATION),-O3) ifeq (clang,$(CLANG)) - REDIS_CFLAGS+=-flto + SERVER_CFLAGS+=-flto else - REDIS_CFLAGS+=-flto=auto + SERVER_CFLAGS+=-flto=auto endif - REDIS_LDFLAGS+=-O3 -flto + SERVER_LDFLAGS+=-O3 -flto endif DEPENDENCY_TARGETS=hiredis linenoise lua hdr_histogram fpconv NODEPS:=clean distclean @@ -116,8 +116,8 @@ endif # Override default settings if possible -include .make-settings -FINAL_CFLAGS=$(STD) $(WARN) $(OPT) $(DEBUG) $(CFLAGS) $(REDIS_CFLAGS) -FINAL_LDFLAGS=$(LDFLAGS) $(REDIS_LDFLAGS) $(DEBUG) +FINAL_CFLAGS=$(STD) $(WARN) $(OPT) $(DEBUG) $(CFLAGS) $(SERVER_CFLAGS) +FINAL_LDFLAGS=$(LDFLAGS) $(SERVER_LDFLAGS) $(DEBUG) FINAL_LIBS=-lm DEBUG=-g -ggdb @@ -297,7 +297,7 @@ ifeq ($(BUILD_TLS),yes) endif TLS_MODULE= -TLS_MODULE_NAME:=redis-tls$(PROG_SUFFIX).so +TLS_MODULE_NAME:=valkey-tls$(PROG_SUFFIX).so TLS_MODULE_CFLAGS:=$(FINAL_CFLAGS) ifeq ($(BUILD_TLS),module) FINAL_CFLAGS+=-DUSE_OPENSSL=$(BUILD_MODULE) $(OPENSSL_CFLAGS) @@ -335,7 +335,7 @@ QUIET_LINK = @printf ' %b %b\n' $(LINKCOLOR)LINK$(ENDCOLOR) $(BINCOLOR)$@$(EN QUIET_INSTALL = @printf ' %b %b\n' $(LINKCOLOR)INSTALL$(ENDCOLOR) $(BINCOLOR)$@$(ENDCOLOR) 1>&2; endif -ifneq (, $(findstring LOG_REQ_RES, $(REDIS_CFLAGS))) +ifneq (, $(findstring LOG_REQ_RES, $(SERVER_CFLAGS))) COMMANDS_DEF_FILENAME=commands_with_reply_schema GEN_COMMANDS_FLAGS=--with-reply-schema else @@ -343,15 +343,15 @@ else GEN_COMMANDS_FLAGS= endif -REDIS_SERVER_NAME=redis-server$(PROG_SUFFIX) -REDIS_SENTINEL_NAME=redis-sentinel$(PROG_SUFFIX) -REDIS_SERVER_OBJ=adlist.o quicklist.o ae.o anet.o dict.o server.o sds.o zmalloc.o lzf_c.o lzf_d.o pqsort.o zipmap.o sha1.o ziplist.o release.o networking.o util.o object.o db.o replication.o rdb.o t_string.o t_list.o t_set.o t_zset.o t_hash.o config.o aof.o pubsub.o multi.o debug.o sort.o intset.o syncio.o cluster.o crc16.o endianconv.o slowlog.o eval.o bio.o rio.o rand.o memtest.o syscheck.o crcspeed.o crc64.o bitops.o sentinel.o notify.o setproctitle.o blocked.o hyperloglog.o latency.o sparkline.o redis-check-rdb.o redis-check-aof.o geo.o lazyfree.o module.o evict.o expire.o geohash.o geohash_helper.o childinfo.o defrag.o siphash.o rax.o t_stream.o listpack.o localtime.o lolwut.o lolwut5.o lolwut6.o acl.o tracking.o socket.o tls.o sha256.o timeout.o setcpuaffinity.o monotonic.o mt19937-64.o resp_parser.o call_reply.o script_lua.o script.o functions.o function_lua.o commands.o strl.o connection.o unix.o logreqres.o -REDIS_CLI_NAME=redis-cli$(PROG_SUFFIX) -REDIS_CLI_OBJ=anet.o adlist.o dict.o redis-cli.o zmalloc.o release.o ae.o redisassert.o crcspeed.o crc64.o siphash.o crc16.o monotonic.o cli_common.o mt19937-64.o strl.o cli_commands.o -REDIS_BENCHMARK_NAME=redis-benchmark$(PROG_SUFFIX) -REDIS_BENCHMARK_OBJ=ae.o anet.o redis-benchmark.o adlist.o dict.o zmalloc.o redisassert.o release.o crcspeed.o crc64.o siphash.o crc16.o monotonic.o cli_common.o mt19937-64.o strl.o -REDIS_CHECK_RDB_NAME=redis-check-rdb$(PROG_SUFFIX) -REDIS_CHECK_AOF_NAME=redis-check-aof$(PROG_SUFFIX) +REDIS_SERVER_NAME=valkey-server$(PROG_SUFFIX) +REDIS_SENTINEL_NAME=valkey-sentinel$(PROG_SUFFIX) +REDIS_SERVER_OBJ=adlist.o quicklist.o ae.o anet.o dict.o server.o sds.o zmalloc.o lzf_c.o lzf_d.o pqsort.o zipmap.o sha1.o ziplist.o release.o networking.o util.o object.o db.o replication.o rdb.o t_string.o t_list.o t_set.o t_zset.o t_hash.o config.o aof.o pubsub.o multi.o debug.o sort.o intset.o syncio.o cluster.o crc16.o endianconv.o slowlog.o eval.o bio.o rio.o rand.o memtest.o syscheck.o crcspeed.o crc64.o bitops.o sentinel.o notify.o setproctitle.o blocked.o hyperloglog.o latency.o sparkline.o valkey-check-rdb.o valkey-check-aof.o geo.o lazyfree.o module.o evict.o expire.o geohash.o geohash_helper.o childinfo.o defrag.o siphash.o rax.o t_stream.o listpack.o localtime.o lolwut.o lolwut5.o lolwut6.o acl.o tracking.o socket.o tls.o sha256.o timeout.o setcpuaffinity.o monotonic.o mt19937-64.o resp_parser.o call_reply.o script_lua.o script.o functions.o function_lua.o commands.o strl.o connection.o unix.o logreqres.o +REDIS_CLI_NAME=valkey-cli$(PROG_SUFFIX) +REDIS_CLI_OBJ=anet.o adlist.o dict.o valkey-cli.o zmalloc.o release.o ae.o redisassert.o crcspeed.o crc64.o siphash.o crc16.o monotonic.o cli_common.o mt19937-64.o strl.o cli_commands.o +REDIS_BENCHMARK_NAME=valkey-benchmark$(PROG_SUFFIX) +REDIS_BENCHMARK_OBJ=ae.o anet.o valkey-benchmark.o adlist.o dict.o zmalloc.o redisassert.o release.o crcspeed.o crc64.o siphash.o crc16.o monotonic.o cli_common.o mt19937-64.o strl.o +REDIS_CHECK_RDB_NAME=valkey-check-rdb$(PROG_SUFFIX) +REDIS_CHECK_AOF_NAME=valkey-check-aof$(PROG_SUFFIX) ALL_SOURCES=$(sort $(patsubst %.o,%.c,$(REDIS_SERVER_OBJ) $(REDIS_CLI_OBJ) $(REDIS_BENCHMARK_OBJ))) all: $(REDIS_SERVER_NAME) $(REDIS_SENTINEL_NAME) $(REDIS_CLI_NAME) $(REDIS_BENCHMARK_NAME) $(REDIS_CHECK_RDB_NAME) $(REDIS_CHECK_AOF_NAME) $(TLS_MODULE) @@ -377,8 +377,8 @@ persist-settings: distclean echo USE_SYSTEMD=$(USE_SYSTEMD) >> .make-settings echo CFLAGS=$(CFLAGS) >> .make-settings echo LDFLAGS=$(LDFLAGS) >> .make-settings - echo REDIS_CFLAGS=$(REDIS_CFLAGS) >> .make-settings - echo REDIS_LDFLAGS=$(REDIS_LDFLAGS) >> .make-settings + echo SERVER_CFLAGS=$(SERVER_CFLAGS) >> .make-settings + echo SERVER_LDFLAGS=$(SERVER_LDFLAGS) >> .make-settings echo PREV_FINAL_CFLAGS=$(FINAL_CFLAGS) >> .make-settings echo PREV_FINAL_LDFLAGS=$(FINAL_LDFLAGS) >> .make-settings -(cd ../deps && $(MAKE) $(DEPENDENCY_TARGETS)) @@ -398,31 +398,31 @@ ifneq ($(strip $(PREV_FINAL_LDFLAGS)), $(strip $(FINAL_LDFLAGS))) .make-prerequisites: persist-settings endif -# redis-server +# valkey-server $(REDIS_SERVER_NAME): $(REDIS_SERVER_OBJ) $(REDIS_LD) -o $@ $^ ../deps/hiredis/libhiredis.a ../deps/lua/src/liblua.a ../deps/hdr_histogram/libhdrhistogram.a ../deps/fpconv/libfpconv.a $(FINAL_LIBS) -# redis-sentinel +# valkey-sentinel $(REDIS_SENTINEL_NAME): $(REDIS_SERVER_NAME) $(REDIS_INSTALL) $(REDIS_SERVER_NAME) $(REDIS_SENTINEL_NAME) -# redis-check-rdb +# valkey-check-rdb $(REDIS_CHECK_RDB_NAME): $(REDIS_SERVER_NAME) $(REDIS_INSTALL) $(REDIS_SERVER_NAME) $(REDIS_CHECK_RDB_NAME) -# redis-check-aof +# valkey-check-aof $(REDIS_CHECK_AOF_NAME): $(REDIS_SERVER_NAME) $(REDIS_INSTALL) $(REDIS_SERVER_NAME) $(REDIS_CHECK_AOF_NAME) -# redis-tls.so +# valkey-tls.so $(TLS_MODULE_NAME): $(REDIS_SERVER_NAME) $(QUIET_CC)$(CC) -o $@ tls.c -shared -fPIC $(TLS_MODULE_CFLAGS) $(TLS_CLIENT_LIBS) -# redis-cli +# valkey-cli $(REDIS_CLI_NAME): $(REDIS_CLI_OBJ) $(REDIS_LD) -o $@ $^ ../deps/hiredis/libhiredis.a ../deps/linenoise/linenoise.o $(FINAL_LIBS) $(TLS_CLIENT_LIBS) -# redis-benchmark +# valkey-benchmark $(REDIS_BENCHMARK_NAME): $(REDIS_BENCHMARK_OBJ) $(REDIS_LD) -o $@ $^ ../deps/hiredis/libhiredis.a ../deps/hdr_histogram/libhdrhistogram.a $(FINAL_LIBS) $(TLS_CLIENT_LIBS) @@ -490,7 +490,7 @@ bench: $(REDIS_BENCHMARK_NAME) $(MAKE) CFLAGS="-m32" LDFLAGS="-m32" gcov: - $(MAKE) REDIS_CFLAGS="-fprofile-arcs -ftest-coverage -DCOVERAGE_TEST" REDIS_LDFLAGS="-fprofile-arcs -ftest-coverage" + $(MAKE) SERVER_CFLAGS="-fprofile-arcs -ftest-coverage -DCOVERAGE_TEST" SERVER_LDFLAGS="-fprofile-arcs -ftest-coverage" noopt: $(MAKE) OPTIMIZATION="-O0" @@ -499,7 +499,7 @@ valgrind: $(MAKE) OPTIMIZATION="-O0" MALLOC="libc" helgrind: - $(MAKE) OPTIMIZATION="-O0" MALLOC="libc" CFLAGS="-D__ATOMIC_VAR_FORCE_SYNC_MACROS" REDIS_CFLAGS="-I/usr/local/include" REDIS_LDFLAGS="-L/usr/local/lib" + $(MAKE) OPTIMIZATION="-O0" MALLOC="libc" CFLAGS="-D__ATOMIC_VAR_FORCE_SYNC_MACROS" SERVER_CFLAGS="-I/usr/local/include" SERVER_LDFLAGS="-L/usr/local/lib" install: all @mkdir -p $(INSTALL_BIN) diff --git a/src/aof.c b/src/aof.c index a89142b30..8bb0e4e67 100644 --- a/src/aof.c +++ b/src/aof.c @@ -251,7 +251,7 @@ void aofLoadManifestFromDisk(void) { sdsfree(am_filepath); } -/* Generic manifest loading function, used in `aofLoadManifestFromDisk` and redis-check-aof tool. */ +/* Generic manifest loading function, used in `aofLoadManifestFromDisk` and valkey-check-aof tool. */ #define MANIFEST_MAX_LINE 1024 aofManifest *aofLoadManifestFromFile(sds am_filepath) { const char *err = NULL; @@ -1625,14 +1625,14 @@ uxeof: /* Unexpected AOF end of file. */ } } serverLog(LL_WARNING, "Unexpected end of file reading the append only file %s. You can: " - "1) Make a backup of your AOF file, then use ./redis-check-aof --fix . " + "1) Make a backup of your AOF file, then use ./valkey-check-aof --fix . " "2) Alternatively you can set the 'aof-load-truncated' configuration option to yes and restart the server.", filename); ret = AOF_FAILED; goto cleanup; fmterr: /* Format error. */ serverLog(LL_WARNING, "Bad file format reading the append only file %s: " - "make a backup of your AOF file, then use ./redis-check-aof --fix ", filename); + "make a backup of your AOF file, then use ./valkey-check-aof --fix ", filename); ret = AOF_FAILED; /* fall through to cleanup. */ diff --git a/src/server.c b/src/server.c index 438325f28..10f10976b 100644 --- a/src/server.c +++ b/src/server.c @@ -7129,9 +7129,9 @@ int main(int argc, char **argv) { /* Check if we need to start in redis-check-rdb/aof mode. We just execute * the program main. However the program is part of the Redis executable * so that we can easily execute an RDB check on loading errors. */ - if (strstr(exec_name,"redis-check-rdb") != NULL) + if (strstr(exec_name,"valkey-check-rdb") != NULL) redis_check_rdb_main(argc,argv,NULL); - else if (strstr(exec_name,"redis-check-aof") != NULL) + else if (strstr(exec_name,"valkey-check-aof") != NULL) redis_check_aof_main(argc,argv); if (argc >= 2) { diff --git a/src/redis-benchmark.c b/src/valkey-benchmark.c similarity index 100% rename from src/redis-benchmark.c rename to src/valkey-benchmark.c diff --git a/src/redis-check-aof.c b/src/valkey-check-aof.c similarity index 99% rename from src/redis-check-aof.c rename to src/valkey-check-aof.c index 616177a8b..55e318a06 100644 --- a/src/redis-check-aof.c +++ b/src/valkey-check-aof.c @@ -199,7 +199,7 @@ int processAnnotations(FILE *fp, char *filename, int last_file) { printf("Failed to truncate AOF %s to timestamp %ld to offset %ld because it is not the last file.\n", filename, to_timestamp, (long int)epos); printf("If you insist, please delete all files after this file according to the manifest " - "file and delete the corresponding records in manifest file manually. Then re-run redis-check-aof.\n"); + "file and delete the corresponding records in manifest file manually. Then re-run valkey-check-aof.\n"); exit(1); } /* Truncate remaining AOF if exceeding 'to_timestamp' */ @@ -416,7 +416,7 @@ int fileIsManifest(char *filepath) { * AOF_RDB_PREAMBLE: Old-style RDB-preamble AOF * AOF_MULTI_PART: manifest in Multi Part AOF * - * redis-check-aof tool will automatically perform different + * valkey-check-aof tool will automatically perform different * verification logic according to different file formats. * */ input_file_type getInputFileType(char *filepath) { diff --git a/src/redis-check-rdb.c b/src/valkey-check-rdb.c similarity index 100% rename from src/redis-check-rdb.c rename to src/valkey-check-rdb.c diff --git a/src/redis-cli.c b/src/valkey-cli.c similarity index 100% rename from src/redis-cli.c rename to src/valkey-cli.c diff --git a/tests/cluster/tests/04-resharding.tcl b/tests/cluster/tests/04-resharding.tcl index 18a26bda6..f7cb7e498 100644 --- a/tests/cluster/tests/04-resharding.tcl +++ b/tests/cluster/tests/04-resharding.tcl @@ -84,7 +84,7 @@ test "Cluster consistency during live resharding" { flush stdout set target [dict get [get_myself [randomInt 5]] id] set tribpid [lindex [exec \ - ../../../src/redis-cli --cluster reshard \ + ../../../src/valkey-cli --cluster reshard \ 127.0.0.1:[get_instance_attrib redis 0 port] \ --cluster-from all \ --cluster-to $target \ diff --git a/tests/cluster/tests/12-replica-migration-2.tcl b/tests/cluster/tests/12-replica-migration-2.tcl index ed680061c..5c3edeb8e 100644 --- a/tests/cluster/tests/12-replica-migration-2.tcl +++ b/tests/cluster/tests/12-replica-migration-2.tcl @@ -38,7 +38,7 @@ test "Set allow-replica-migration yes" { set master0_id [dict get [get_myself 0] id] test "Resharding all the master #0 slots away from it" { set output [exec \ - ../../../src/redis-cli --cluster rebalance \ + ../../../src/valkey-cli --cluster rebalance \ 127.0.0.1:[get_instance_attrib redis 0 port] \ {*}[rediscli_tls_config "../../../tests"] \ --cluster-weight ${master0_id}=0 >@ stdout ] @@ -59,7 +59,7 @@ test "Resharding back some slot to master #0" { # new resharding. after 10000 set output [exec \ - ../../../src/redis-cli --cluster rebalance \ + ../../../src/valkey-cli --cluster rebalance \ 127.0.0.1:[get_instance_attrib redis 0 port] \ {*}[rediscli_tls_config "../../../tests"] \ --cluster-weight ${master0_id}=.01 \ diff --git a/tests/cluster/tests/12.1-replica-migration-3.tcl b/tests/cluster/tests/12.1-replica-migration-3.tcl index 790c73209..3515425e1 100644 --- a/tests/cluster/tests/12.1-replica-migration-3.tcl +++ b/tests/cluster/tests/12.1-replica-migration-3.tcl @@ -37,7 +37,7 @@ test "Set allow-replica-migration no" { set master0_id [dict get [get_myself 0] id] test "Resharding all the master #0 slots away from it" { set output [exec \ - ../../../src/redis-cli --cluster rebalance \ + ../../../src/valkey-cli --cluster rebalance \ 127.0.0.1:[get_instance_attrib redis 0 port] \ {*}[rediscli_tls_config "../../../tests"] \ --cluster-weight ${master0_id}=0 >@ stdout ] diff --git a/tests/cluster/tests/helpers/onlydots.tcl b/tests/cluster/tests/helpers/onlydots.tcl index 4a6d1aee0..2c398ab3a 100644 --- a/tests/cluster/tests/helpers/onlydots.tcl +++ b/tests/cluster/tests/helpers/onlydots.tcl @@ -1,7 +1,7 @@ # Read the standard input and only shows dots in the output, filtering out # all the other characters. Designed to avoid bufferization so that when -# we get the output of redis-trib and want to show just the dots, we'll see -# the dots as soon as redis-trib will output them. +# we get the output of valkey-trib and want to show just the dots, we'll see +# the dots as soon as valkey-trib will output them. fconfigure stdin -buffering none diff --git a/tests/cluster/tests/includes/utils.tcl b/tests/cluster/tests/includes/utils.tcl index c1b0fe6b7..689249259 100644 --- a/tests/cluster/tests/includes/utils.tcl +++ b/tests/cluster/tests/includes/utils.tcl @@ -8,25 +8,25 @@ proc config_set_all_nodes {keyword value} { proc fix_cluster {addr} { set code [catch { - exec ../../../src/redis-cli {*}[rediscli_tls_config "../../../tests"] --cluster fix $addr << yes + exec ../../../src/valkey-cli {*}[rediscli_tls_config "../../../tests"] --cluster fix $addr << yes } result] if {$code != 0} { - puts "redis-cli --cluster fix returns non-zero exit code, output below:\n$result" + puts "valkey-cli --cluster fix returns non-zero exit code, output below:\n$result" } - # Note: redis-cli --cluster fix may return a non-zero exit code if nodes don't agree, + # Note: valkey-cli --cluster fix may return a non-zero exit code if nodes don't agree, # but we can ignore that and rely on the check below. assert_cluster_state ok wait_for_condition 100 100 { - [catch {exec ../../../src/redis-cli {*}[rediscli_tls_config "../../../tests"] --cluster check $addr} result] == 0 + [catch {exec ../../../src/valkey-cli {*}[rediscli_tls_config "../../../tests"] --cluster check $addr} result] == 0 } else { - puts "redis-cli --cluster check returns non-zero exit code, output below:\n$result" + puts "valkey-cli --cluster check returns non-zero exit code, output below:\n$result" fail "Cluster could not settle with configuration" } } proc wait_cluster_stable {} { wait_for_condition 1000 50 { - [catch {exec ../../../src/redis-cli --cluster \ + [catch {exec ../../../src/valkey-cli --cluster \ check 127.0.0.1:[get_instance_attrib redis 0 port] \ {*}[rediscli_tls_config "../../../tests"] \ }] == 0 diff --git a/tests/instances.tcl b/tests/instances.tcl index 56a51a872..d729de508 100644 --- a/tests/instances.tcl +++ b/tests/instances.tcl @@ -48,9 +48,9 @@ if {[catch {cd tmp}]} { # the provided configuration file. Returns the PID of the process. proc exec_instance {type dirname cfgfile} { if {$type eq "redis"} { - set prgname redis-server + set prgname valkey-server } elseif {$type eq "sentinel"} { - set prgname redis-sentinel + set prgname valkey-sentinel } else { error "Unknown instance type." } @@ -87,7 +87,7 @@ proc spawn_instance {type base_port count {conf {}} {base_conf_file ""}} { if {$::tls} { if {$::tls_module} { - puts $cfg [format "loadmodule %s/../../../src/redis-tls.so" [pwd]] + puts $cfg [format "loadmodule %s/../../../src/valkey-tls.so" [pwd]] } puts $cfg "tls-port $port" @@ -342,7 +342,7 @@ proc pause_on_error {} { set cmd [lindex $argv 0] if {$cmd eq {continue}} { break - } elseif {$cmd eq {show-redis-logs}} { + } elseif {$cmd eq {show-valkey-logs}} { set count 10 if {[lindex $argv 1] ne {}} {set count [lindex $argv 1]} foreach_redis_id id { @@ -393,7 +393,7 @@ proc pause_on_error {} { } elseif {$cmd eq {help}} { puts "ls List Sentinel and Redis instances." puts "show-sentinel-logs \[N\] Show latest N lines of logs." - puts "show-redis-logs \[N\] Show latest N lines of logs." + puts "show-valkey-logs \[N\] Show latest N lines of logs." puts "S cmd ... arg Call command in Sentinel ." puts "R cmd ... arg Call command in Redis ." puts "SI Show Sentinel INFO ." diff --git a/tests/integration/aof-race.tcl b/tests/integration/aof-race.tcl index 32f3a742a..d49be0462 100644 --- a/tests/integration/aof-race.tcl +++ b/tests/integration/aof-race.tcl @@ -8,7 +8,7 @@ tags {"aof external:skip"} { # was subsequently appended to the new AOF, resulting in duplicate commands. start_server_aof [list dir $server_path] { set client [redis [dict get $srv host] [dict get $srv port] 0 $::tls] - set bench [open "|src/redis-benchmark -q -s [dict get $srv unixsocket] -c 20 -n 20000 incr foo" "r+"] + set bench [open "|src/valkey-benchmark -q -s [dict get $srv unixsocket] -c 20 -n 20000 incr foo" "r+"] wait_for_condition 100 1 { [$client get foo] > 0 diff --git a/tests/integration/aof.tcl b/tests/integration/aof.tcl index 1f73fc341..4aeae0f5b 100644 --- a/tests/integration/aof.tcl +++ b/tests/integration/aof.tcl @@ -140,10 +140,10 @@ tags {"aof external:skip"} { } } - ## Test that redis-check-aof indeed sees this AOF is not valid + ## Test that valkey-check-aof indeed sees this AOF is not valid test "Short read: Utility should confirm the AOF is not valid" { catch { - exec src/redis-check-aof $aof_manifest_file + exec src/valkey-check-aof $aof_manifest_file } result assert_match "*not valid*" $result } @@ -155,13 +155,13 @@ tags {"aof external:skip"} { } catch { - exec src/redis-check-aof $aof_manifest_file + exec src/valkey-check-aof $aof_manifest_file } result assert_match "*ok_up_to_line=8*" $result } test "Short read: Utility should be able to fix the AOF" { - set result [exec src/redis-check-aof --fix $aof_manifest_file << "y\n"] + set result [exec src/valkey-check-aof --fix $aof_manifest_file << "y\n"] assert_match "*Successfully truncated AOF*" $result } @@ -445,7 +445,7 @@ tags {"aof external:skip"} { test {Truncate AOF to specific timestamp} { # truncate to timestamp 1628217473 - exec src/redis-check-aof --truncate-to-timestamp 1628217473 $aof_manifest_file + exec src/valkey-check-aof --truncate-to-timestamp 1628217473 $aof_manifest_file start_server_aof [list dir $server_path] { set c [redis [dict get $srv host] [dict get $srv port] 0 $::tls] wait_done_loading $c @@ -455,7 +455,7 @@ tags {"aof external:skip"} { } # truncate to timestamp 1628217471 - exec src/redis-check-aof --truncate-to-timestamp 1628217471 $aof_manifest_file + exec src/valkey-check-aof --truncate-to-timestamp 1628217471 $aof_manifest_file start_server_aof [list dir $server_path] { set c [redis [dict get $srv host] [dict get $srv port] 0 $::tls] wait_done_loading $c @@ -465,7 +465,7 @@ tags {"aof external:skip"} { } # truncate to timestamp 1628217470 - exec src/redis-check-aof --truncate-to-timestamp 1628217470 $aof_manifest_file + exec src/valkey-check-aof --truncate-to-timestamp 1628217470 $aof_manifest_file start_server_aof [list dir $server_path] { set c [redis [dict get $srv host] [dict get $srv port] 0 $::tls] wait_done_loading $c @@ -474,7 +474,7 @@ tags {"aof external:skip"} { } # truncate to timestamp 1628217469 - catch {exec src/redis-check-aof --truncate-to-timestamp 1628217469 $aof_manifest_file} e + catch {exec src/valkey-check-aof --truncate-to-timestamp 1628217469 $aof_manifest_file} e assert_match {*aborting*} $e } @@ -517,26 +517,26 @@ tags {"aof external:skip"} { } } - test {Test redis-check-aof for old style resp AOF} { + test {Test valkey-check-aof for old style resp AOF} { create_aof $aof_dirpath $aof_file { append_to_aof [formatCommand set foo hello] append_to_aof [formatCommand set bar world] } catch { - exec src/redis-check-aof $aof_file + exec src/valkey-check-aof $aof_file } result assert_match "*Start checking Old-Style AOF*is valid*" $result } - test {Test redis-check-aof for old style rdb-preamble AOF} { + test {Test valkey-check-aof for old style rdb-preamble AOF} { catch { - exec src/redis-check-aof tests/assets/rdb-preamble.aof + exec src/valkey-check-aof tests/assets/rdb-preamble.aof } result assert_match "*Start checking Old-Style AOF*RDB preamble is OK, proceeding with AOF tail*is valid*" $result } - test {Test redis-check-aof for Multi Part AOF with resp AOF base} { + test {Test valkey-check-aof for Multi Part AOF with resp AOF base} { create_aof $aof_dirpath $aof_base_file { append_to_aof [formatCommand set foo hello] append_to_aof [formatCommand set bar world] @@ -553,12 +553,12 @@ tags {"aof external:skip"} { } catch { - exec src/redis-check-aof $aof_manifest_file + exec src/valkey-check-aof $aof_manifest_file } result assert_match "*Start checking Multi Part AOF*Start to check BASE AOF (RESP format)*BASE AOF*is valid*Start to check INCR files*INCR AOF*is valid*All AOF files and manifest are valid*" $result } - test {Test redis-check-aof for Multi Part AOF with rdb-preamble AOF base} { + test {Test valkey-check-aof for Multi Part AOF with rdb-preamble AOF base} { exec cp tests/assets/rdb-preamble.aof $aof_base_file create_aof $aof_dirpath $aof_file { @@ -572,12 +572,12 @@ tags {"aof external:skip"} { } catch { - exec src/redis-check-aof $aof_manifest_file + exec src/valkey-check-aof $aof_manifest_file } result assert_match "*Start checking Multi Part AOF*Start to check BASE AOF (RDB format)*DB preamble is OK, proceeding with AOF tail*BASE AOF*is valid*Start to check INCR files*INCR AOF*is valid*All AOF files and manifest are valid*" $result } - test {Test redis-check-aof only truncates the last file for Multi Part AOF in fix mode} { + test {Test valkey-check-aof only truncates the last file for Multi Part AOF in fix mode} { create_aof $aof_dirpath $aof_base_file { append_to_aof [formatCommand set foo hello] append_to_aof [formatCommand multi] @@ -595,17 +595,17 @@ tags {"aof external:skip"} { } catch { - exec src/redis-check-aof $aof_manifest_file + exec src/valkey-check-aof $aof_manifest_file } result assert_match "*not valid*" $result catch { - exec src/redis-check-aof --fix $aof_manifest_file + exec src/valkey-check-aof --fix $aof_manifest_file } result assert_match "*Failed to truncate AOF*because it is not the last file*" $result } - test {Test redis-check-aof only truncates the last file for Multi Part AOF in truncate-to-timestamp mode} { + test {Test valkey-check-aof only truncates the last file for Multi Part AOF in truncate-to-timestamp mode} { create_aof $aof_dirpath $aof_base_file { append_to_aof "#TS:1628217470\r\n" append_to_aof [formatCommand set foo1 bar1] @@ -628,7 +628,7 @@ tags {"aof external:skip"} { } catch { - exec src/redis-check-aof --truncate-to-timestamp 1628217473 $aof_manifest_file + exec src/valkey-check-aof --truncate-to-timestamp 1628217473 $aof_manifest_file } result assert_match "*Failed to truncate AOF*to timestamp*because it is not the last file*" $result } diff --git a/tests/integration/logging.tcl b/tests/integration/logging.tcl index 4f8639be0..27a3a4eaf 100644 --- a/tests/integration/logging.tcl +++ b/tests/integration/logging.tcl @@ -10,7 +10,7 @@ if {$system_name eq {darwin}} { # Avoid the test on libmusl, which does not support backtrace # and on static binaries (ldd exit code 1) where we can't detect libmusl catch { - set ldd [exec ldd src/redis-server] + set ldd [exec ldd src/valkey-server] if {![string match {*libc.*musl*} $ldd]} { set backtrace_supported 1 } diff --git a/tests/integration/psync2-reg.tcl b/tests/integration/psync2-reg.tcl index b8dd10104..53a45cf57 100644 --- a/tests/integration/psync2-reg.tcl +++ b/tests/integration/psync2-reg.tcl @@ -1,7 +1,7 @@ # Issue 3899 regression test. # We create a chain of three instances: master -> slave -> slave2 # and continuously break the link while traffic is generated by -# redis-benchmark. At the end we check that the data is the same +# valkey-benchmark. At the end we check that the data is the same # everywhere. start_server {tags {"psync2 external:skip"}} { @@ -40,7 +40,7 @@ start_server {} { } set cycle_start_time [clock milliseconds] - set bench_pid [exec src/redis-benchmark -s $R_unixsocket(0) -n 10000000 -r 1000 incr __rand_int__ > /dev/null &] + set bench_pid [exec src/valkey-benchmark -s $R_unixsocket(0) -n 10000000 -r 1000 incr __rand_int__ > /dev/null &] while 1 { set elapsed [expr {[clock milliseconds]-$cycle_start_time}] if {$elapsed > $duration*1000} break diff --git a/tests/integration/redis-benchmark.tcl b/tests/integration/valkey-benchmark.tcl similarity index 94% rename from tests/integration/redis-benchmark.tcl rename to tests/integration/valkey-benchmark.tcl index 8035632c7..35e32eb5f 100644 --- a/tests/integration/redis-benchmark.tcl +++ b/tests/integration/valkey-benchmark.tcl @@ -5,14 +5,14 @@ proc cmdstat {cmd} { return [cmdrstat $cmd r] } -# common code to reset stats, flush the db and run redis-benchmark +# common code to reset stats, flush the db and run valkey-benchmark proc common_bench_setup {cmd} { r config resetstat r flushall if {[catch { exec {*}$cmd } error]} { set first_line [lindex [split $error "\n"] 0] - puts [colorstr red "redis-benchmark non zero code. first line: $first_line"] - fail "redis-benchmark non zero code. first line: $first_line" + puts [colorstr red "valkey-benchmark non zero code. first line: $first_line"] + fail "valkey-benchmark non zero code. first line: $first_line" } } @@ -156,8 +156,8 @@ start_server {tags {"benchmark network external:skip logreqres:skip"}} { puts "Skipping test, TLSv1.3 not supported." } } else { - puts [colorstr red "redis-benchmark non zero code. first line: $first_line"] - fail "redis-benchmark non zero code. first line: $first_line" + puts [colorstr red "valkey-benchmark non zero code. first line: $first_line"] + fail "valkey-benchmark non zero code. first line: $first_line" } } if {$ciphersuites_supported} { diff --git a/tests/integration/redis-cli.tcl b/tests/integration/valkey-cli.tcl similarity index 99% rename from tests/integration/redis-cli.tcl rename to tests/integration/valkey-cli.tcl index da82dda65..6968e47e2 100644 --- a/tests/integration/redis-cli.tcl +++ b/tests/integration/valkey-cli.tcl @@ -509,7 +509,7 @@ if {!$::tls} { ;# fake_redis_node doesn't support TLS wait_for_condition 500 100 { [string match {*slave0:*state=online*} [r info]] } else { - fail "redis-cli --replica did not connect" + fail "valkey-cli --replica did not connect" } for {set i 0} {$i < 100} {incr i} { @@ -519,7 +519,7 @@ if {!$::tls} { ;# fake_redis_node doesn't support TLS wait_for_condition 500 100 { [string match {*test-value-99*} [read_cli $fd]] } else { - fail "redis-cli --replica didn't read commands" + fail "valkey-cli --replica didn't read commands" } fconfigure $fd -blocking true diff --git a/tests/support/benchmark.tcl b/tests/support/benchmark.tcl index 156b20556..35a8d2623 100644 --- a/tests/support/benchmark.tcl +++ b/tests/support/benchmark.tcl @@ -12,21 +12,21 @@ proc redisbenchmark_tls_config {testsdir} { } proc redisbenchmark {host port {opts {}}} { - set cmd [list src/redis-benchmark -h $host -p $port] + set cmd [list src/valkey-benchmark -h $host -p $port] lappend cmd {*}[redisbenchmark_tls_config "tests"] lappend cmd {*}$opts return $cmd } proc redisbenchmarkuri {host port {opts {}}} { - set cmd [list src/redis-benchmark -u redis://$host:$port] + set cmd [list src/valkey-benchmark -u redis://$host:$port] lappend cmd {*}[redisbenchmark_tls_config "tests"] lappend cmd {*}$opts return $cmd } proc redisbenchmarkuriuserpass {host port user pass {opts {}}} { - set cmd [list src/redis-benchmark -u redis://$user:$pass@$host:$port] + set cmd [list src/valkey-benchmark -u redis://$user:$pass@$host:$port] lappend cmd {*}[redisbenchmark_tls_config "tests"] lappend cmd {*}$opts return $cmd diff --git a/tests/support/cli.tcl b/tests/support/cli.tcl index a080823eb..817b34237 100644 --- a/tests/support/cli.tcl +++ b/tests/support/cli.tcl @@ -11,20 +11,20 @@ proc rediscli_tls_config {testsdir} { } } -# Returns command line for executing redis-cli +# Returns command line for executing valkey-cli proc rediscli {host port {opts {}}} { - set cmd [list src/redis-cli -h $host -p $port] + set cmd [list src/valkey-cli -h $host -p $port] lappend cmd {*}[rediscli_tls_config "tests"] lappend cmd {*}$opts return $cmd } -# Returns command line for executing redis-cli with a unix socket address +# Returns command line for executing valkey-cli with a unix socket address proc rediscli_unixsocket {unixsocket {opts {}}} { - return [list src/redis-cli -s $unixsocket {*}$opts] + return [list src/valkey-cli -s $unixsocket {*}$opts] } -# Run redis-cli with specified args on the server of specified level. +# Run valkey-cli with specified args on the server of specified level. # Returns output broken down into individual lines. proc rediscli_exec {level args} { set cmd [rediscli_unixsocket [srv $level unixsocket] $args] diff --git a/tests/support/server.tcl b/tests/support/server.tcl index 67979e5a9..769b1f5d6 100644 --- a/tests/support/server.tcl +++ b/tests/support/server.tcl @@ -272,7 +272,7 @@ proc create_server_config_file {filename config config_lines} { } proc spawn_server {config_file stdout stderr args} { - set cmd [list src/redis-server $config_file] + set cmd [list src/valkey-server $config_file] set args {*}$args if {[llength $args] > 0} { lappend cmd {*}$args @@ -471,7 +471,7 @@ proc start_server {options {code undefined}} { set config {} if {$::tls} { if {$::tls_module} { - lappend config_lines [list "loadmodule" [format "%s/src/redis-tls.so" [pwd]]] + lappend config_lines [list "loadmodule" [format "%s/src/valkey-tls.so" [pwd]]] } dict set config "tls-cert-file" [format "%s/tests/tls/server.crt" [pwd]] dict set config "tls-key-file" [format "%s/tests/tls/server.key" [pwd]] diff --git a/tests/support/test.tcl b/tests/support/test.tcl index b7cd38b38..6ba3bf365 100644 --- a/tests/support/test.tcl +++ b/tests/support/test.tcl @@ -258,7 +258,7 @@ proc test {name code {okpattern undefined} {tags {}}} { } if {$::traceleaks} { - set output [exec leaks redis-server] + set output [exec leaks valkey-server] if {![string match {*0 leaks*} $output]} { send_data_packet $::test_server_fd err "Detected a memory leak in test '$name': $output" } diff --git a/tests/test_helper.tcl b/tests/test_helper.tcl index 21fa35d4d..1dc12edaf 100644 --- a/tests/test_helper.tcl +++ b/tests/test_helper.tcl @@ -64,8 +64,8 @@ set ::all_tests { integration/psync2-pingoff integration/psync2-master-restart integration/failover - integration/redis-cli - integration/redis-benchmark + integration/valkey-cli + integration/valkey-benchmark integration/dismiss-mem unit/pubsub unit/pubsubshard diff --git a/tests/unit/acl.tcl b/tests/unit/acl.tcl index 36ef06370..20df0e882 100644 --- a/tests/unit/acl.tcl +++ b/tests/unit/acl.tcl @@ -1154,10 +1154,10 @@ start_server [list overrides [list "dir" $server_path "aclfile" "user.acl"] tags } test {Test loading duplicate users in config on startup} { - catch {exec src/redis-server --user foo --user foo} err + catch {exec src/valkey-server --user foo --user foo} err assert_match {*Duplicate user*} $err - catch {exec src/redis-server --user default --user default} err + catch {exec src/valkey-server --user default --user default} err assert_match {*Duplicate user*} $err } {} {external:skip} } diff --git a/tests/unit/cluster/cli.tcl b/tests/unit/cluster/cli.tcl index 76e97210f..071137c53 100644 --- a/tests/unit/cluster/cli.tcl +++ b/tests/unit/cluster/cli.tcl @@ -1,4 +1,4 @@ -# Primitive tests on cluster-enabled redis using redis-cli +# Primitive tests on cluster-enabled redis using valkey-cli source tests/support/cli.tcl @@ -20,7 +20,7 @@ start_multiple_servers 3 [list overrides $base_conf] { set node3_rd [redis_deferring_client -2] test {Create 3 node cluster} { - exec src/redis-cli --cluster-yes --cluster create \ + exec src/valkey-cli --cluster-yes --cluster create \ 127.0.0.1:[srv 0 port] \ 127.0.0.1:[srv -1 port] \ 127.0.0.1:[srv -2 port] @@ -47,7 +47,7 @@ start_multiple_servers 3 [list overrides $base_conf] { } test "Perform a Resharding" { - exec src/redis-cli --cluster-yes --cluster reshard 127.0.0.1:[srv -2 port] \ + exec src/valkey-cli --cluster-yes --cluster reshard 127.0.0.1:[srv -2 port] \ --cluster-to [$node1 cluster myid] \ --cluster-from [$node3 cluster myid] \ --cluster-slots 1 @@ -68,9 +68,9 @@ start_multiple_servers 3 [list overrides $base_conf] { # waiting for cluster_state to be okay is an independent check that all the # nodes actually believe each other are healthy, prevent cluster down error. wait_for_condition 1000 50 { - [catch {exec src/redis-cli --cluster check 127.0.0.1:[srv 0 port]}] == 0 && - [catch {exec src/redis-cli --cluster check 127.0.0.1:[srv -1 port]}] == 0 && - [catch {exec src/redis-cli --cluster check 127.0.0.1:[srv -2 port]}] == 0 && + [catch {exec src/valkey-cli --cluster check 127.0.0.1:[srv 0 port]}] == 0 && + [catch {exec src/valkey-cli --cluster check 127.0.0.1:[srv -1 port]}] == 0 && + [catch {exec src/valkey-cli --cluster check 127.0.0.1:[srv -2 port]}] == 0 && [CI 0 cluster_state] eq {ok} && [CI 1 cluster_state] eq {ok} && [CI 2 cluster_state] eq {ok} @@ -87,13 +87,13 @@ start_multiple_servers 3 [list overrides $base_conf] { set endpoint_type_before_set [lindex [split [$node1 CONFIG GET cluster-preferred-endpoint-type] " "] 1] $node1 CONFIG SET cluster-preferred-endpoint-type unknown-endpoint - # when redis-cli not in cluster mode, return MOVE with empty host + # when valkey-cli not in cluster mode, return MOVE with empty host set slot_for_foo [$node1 CLUSTER KEYSLOT foo] assert_error "*MOVED $slot_for_foo :*" {$node1 set foo bar} # when in cluster mode, redirect using previous hostip - assert_equal "[exec src/redis-cli -h 127.0.0.1 -p [srv 0 port] -c set foo bar]" {OK} - assert_match "[exec src/redis-cli -h 127.0.0.1 -p [srv 0 port] -c get foo]" {bar} + assert_equal "[exec src/valkey-cli -h 127.0.0.1 -p [srv 0 port] -c set foo bar]" {OK} + assert_match "[exec src/valkey-cli -h 127.0.0.1 -p [srv 0 port] -c get foo]" {bar} assert_equal [$node1 CONFIG SET cluster-preferred-endpoint-type "$endpoint_type_before_set"] {OK} } @@ -156,15 +156,15 @@ start_multiple_servers 3 [list overrides $base_conf] { } ;# stop servers -# Test redis-cli -- cluster create, add-node, call. +# Test valkey-cli -- cluster create, add-node, call. # Test that functions are propagated on add-node start_multiple_servers 5 [list overrides $base_conf] { set node4_rd [redis_client -3] set node5_rd [redis_client -4] - test {Functions are added to new node on redis-cli cluster add-node} { - exec src/redis-cli --cluster-yes --cluster create \ + test {Functions are added to new node on valkey-cli cluster add-node} { + exec src/valkey-cli --cluster-yes --cluster create \ 127.0.0.1:[srv 0 port] \ 127.0.0.1:[srv -1 port] \ 127.0.0.1:[srv -2 port] @@ -179,13 +179,13 @@ start_multiple_servers 5 [list overrides $base_conf] { } # upload a function to all the cluster - exec src/redis-cli --cluster-yes --cluster call 127.0.0.1:[srv 0 port] \ + exec src/valkey-cli --cluster-yes --cluster call 127.0.0.1:[srv 0 port] \ FUNCTION LOAD {#!lua name=TEST redis.register_function('test', function() return 'hello' end) } # adding node to the cluster - exec src/redis-cli --cluster-yes --cluster add-node \ + exec src/valkey-cli --cluster-yes --cluster add-node \ 127.0.0.1:[srv -3 port] \ 127.0.0.1:[srv 0 port] @@ -213,7 +213,7 @@ start_multiple_servers 5 [list overrides $base_conf] { # adding node 5 to the cluster should failed because it already contains the 'test' function catch { - exec src/redis-cli --cluster-yes --cluster add-node \ + exec src/valkey-cli --cluster-yes --cluster add-node \ 127.0.0.1:[srv -4 port] \ 127.0.0.1:[srv 0 port] } e @@ -221,13 +221,13 @@ start_multiple_servers 5 [list overrides $base_conf] { } } ;# stop servers -# Test redis-cli --cluster create, add-node. +# Test valkey-cli --cluster create, add-node. # Test that one slot can be migrated to and then away from the new node. -test {Migrate the last slot away from a node using redis-cli} { +test {Migrate the last slot away from a node using valkey-cli} { start_multiple_servers 4 [list overrides $base_conf] { # Create a cluster of 3 nodes - exec src/redis-cli --cluster-yes --cluster create \ + exec src/valkey-cli --cluster-yes --cluster create \ 127.0.0.1:[srv 0 port] \ 127.0.0.1:[srv -1 port] \ 127.0.0.1:[srv -2 port] @@ -241,11 +241,11 @@ test {Migrate the last slot away from a node using redis-cli} { } # Insert some data - assert_equal OK [exec src/redis-cli -c -p [srv 0 port] SET foo bar] - set slot [exec src/redis-cli -c -p [srv 0 port] CLUSTER KEYSLOT foo] + assert_equal OK [exec src/valkey-cli -c -p [srv 0 port] SET foo bar] + set slot [exec src/valkey-cli -c -p [srv 0 port] CLUSTER KEYSLOT foo] # Add new node to the cluster - exec src/redis-cli --cluster-yes --cluster add-node \ + exec src/valkey-cli --cluster-yes --cluster add-node \ 127.0.0.1:[srv -3 port] \ 127.0.0.1:[srv 0 port] @@ -283,10 +283,10 @@ test {Migrate the last slot away from a node using redis-cli} { # Using --cluster check make sure we won't get `Not all slots are covered by nodes`. # Wait for the cluster to become stable make sure the cluster is up during MIGRATE. wait_for_condition 1000 50 { - [catch {exec src/redis-cli --cluster check 127.0.0.1:[srv 0 port]}] == 0 && - [catch {exec src/redis-cli --cluster check 127.0.0.1:[srv -1 port]}] == 0 && - [catch {exec src/redis-cli --cluster check 127.0.0.1:[srv -2 port]}] == 0 && - [catch {exec src/redis-cli --cluster check 127.0.0.1:[srv -3 port]}] == 0 && + [catch {exec src/valkey-cli --cluster check 127.0.0.1:[srv 0 port]}] == 0 && + [catch {exec src/valkey-cli --cluster check 127.0.0.1:[srv -1 port]}] == 0 && + [catch {exec src/valkey-cli --cluster check 127.0.0.1:[srv -2 port]}] == 0 && + [catch {exec src/valkey-cli --cluster check 127.0.0.1:[srv -3 port]}] == 0 && [CI 0 cluster_state] eq {ok} && [CI 1 cluster_state] eq {ok} && [CI 2 cluster_state] eq {ok} && @@ -295,8 +295,8 @@ test {Migrate the last slot away from a node using redis-cli} { fail "Cluster doesn't stabilize" } - # Move the only slot back to original node using redis-cli - exec src/redis-cli --cluster reshard 127.0.0.1:[srv -3 port] \ + # Move the only slot back to original node using valkey-cli + exec src/valkey-cli --cluster reshard 127.0.0.1:[srv -3 port] \ --cluster-from $newnode_id \ --cluster-to $owner_id \ --cluster-slots 1 \ @@ -327,7 +327,7 @@ test {Migrate the last slot away from a node using redis-cli} { } } -# Test redis-cli --cluster create, add-node with cluster-port. +# Test valkey-cli --cluster create, add-node with cluster-port. # Create five nodes, three with custom cluster_port and two with default values. start_server [list overrides [list cluster-enabled yes cluster-node-timeout 1 cluster-port [find_available_port $::baseport $::portcount]]] { start_server [list overrides [list cluster-enabled yes cluster-node-timeout 1]] { @@ -343,8 +343,8 @@ start_server [list overrides [list cluster-enabled yes cluster-node-timeout 1 cl set node4_rd [redis_client -3] set node5_rd [redis_client -4] - test {redis-cli --cluster create with cluster-port} { - exec src/redis-cli --cluster-yes --cluster create \ + test {valkey-cli --cluster create with cluster-port} { + exec src/valkey-cli --cluster-yes --cluster create \ 127.0.0.1:[srv 0 port] \ 127.0.0.1:[srv -1 port] \ 127.0.0.1:[srv -2 port] @@ -363,9 +363,9 @@ start_server [list overrides [list cluster-enabled yes cluster-node-timeout 1 cl assert_equal 3 [CI 2 cluster_known_nodes] } - test {redis-cli --cluster add-node with cluster-port} { + test {valkey-cli --cluster add-node with cluster-port} { # Adding node to the cluster (without cluster-port) - exec src/redis-cli --cluster-yes --cluster add-node \ + exec src/valkey-cli --cluster-yes --cluster add-node \ 127.0.0.1:[srv -3 port] \ 127.0.0.1:[srv 0 port] @@ -381,7 +381,7 @@ start_server [list overrides [list cluster-enabled yes cluster-node-timeout 1 cl } # Adding node to the cluster (with cluster-port) - exec src/redis-cli --cluster-yes --cluster add-node \ + exec src/valkey-cli --cluster-yes --cluster add-node \ 127.0.0.1:[srv -4 port] \ 127.0.0.1:[srv 0 port] diff --git a/tests/unit/introspection.tcl b/tests/unit/introspection.tcl index 8132ee197..411ccdbe1 100644 --- a/tests/unit/introspection.tcl +++ b/tests/unit/introspection.tcl @@ -630,57 +630,57 @@ start_server {tags {"introspection"}} { assert {[dict exists $res bind]} } - test {redis-server command line arguments - error cases} { + test {valkey-server command line arguments - error cases} { # Take '--invalid' as the option. - catch {exec src/redis-server --invalid} err + catch {exec src/valkey-server --invalid} err assert_match {*Bad directive or wrong number of arguments*} $err - catch {exec src/redis-server --port} err + catch {exec src/valkey-server --port} err assert_match {*'port'*wrong number of arguments*} $err - catch {exec src/redis-server --port 6380 --loglevel} err + catch {exec src/valkey-server --port 6380 --loglevel} err assert_match {*'loglevel'*wrong number of arguments*} $err # Take `6379` and `6380` as the port option value. - catch {exec src/redis-server --port 6379 6380} err + catch {exec src/valkey-server --port 6379 6380} err assert_match {*'port "6379" "6380"'*wrong number of arguments*} $err # Take `--loglevel` and `verbose` as the port option value. - catch {exec src/redis-server --port --loglevel verbose} err + catch {exec src/valkey-server --port --loglevel verbose} err assert_match {*'port "--loglevel" "verbose"'*wrong number of arguments*} $err # Take `--bla` as the port option value. - catch {exec src/redis-server --port --bla --loglevel verbose} err + catch {exec src/valkey-server --port --bla --loglevel verbose} err assert_match {*'port "--bla"'*argument couldn't be parsed into an integer*} $err # Take `--bla` as the loglevel option value. - catch {exec src/redis-server --logfile --my--log--file --loglevel --bla} err + catch {exec src/valkey-server --logfile --my--log--file --loglevel --bla} err assert_match {*'loglevel "--bla"'*argument(s) must be one of the following*} $err # Using MULTI_ARG's own check, empty option value - catch {exec src/redis-server --shutdown-on-sigint} err + catch {exec src/valkey-server --shutdown-on-sigint} err assert_match {*'shutdown-on-sigint'*argument(s) must be one of the following*} $err - catch {exec src/redis-server --shutdown-on-sigint "now force" --shutdown-on-sigterm} err + catch {exec src/valkey-server --shutdown-on-sigint "now force" --shutdown-on-sigterm} err assert_match {*'shutdown-on-sigterm'*argument(s) must be one of the following*} $err - # Something like `redis-server --some-config --config-value1 --config-value2 --loglevel debug` would break, + # Something like `valkey-server --some-config --config-value1 --config-value2 --loglevel debug` would break, # because if you want to pass a value to a config starting with `--`, it can only be a single value. - catch {exec src/redis-server --replicaof 127.0.0.1 abc} err + catch {exec src/valkey-server --replicaof 127.0.0.1 abc} err assert_match {*'replicaof "127.0.0.1" "abc"'*Invalid master port*} $err - catch {exec src/redis-server --replicaof --127.0.0.1 abc} err + catch {exec src/valkey-server --replicaof --127.0.0.1 abc} err assert_match {*'replicaof "--127.0.0.1" "abc"'*Invalid master port*} $err - catch {exec src/redis-server --replicaof --127.0.0.1 --abc} err + catch {exec src/valkey-server --replicaof --127.0.0.1 --abc} err assert_match {*'replicaof "--127.0.0.1"'*wrong number of arguments*} $err } {} {external:skip} - test {redis-server command line arguments - allow passing option name and option value in the same arg} { + test {valkey-server command line arguments - allow passing option name and option value in the same arg} { start_server {config "default.conf" args {"--maxmemory 700mb" "--maxmemory-policy volatile-lru"}} { assert_match [r config get maxmemory] {maxmemory 734003200} assert_match [r config get maxmemory-policy] {maxmemory-policy volatile-lru} } } {} {external:skip} - test {redis-server command line arguments - wrong usage that we support anyway} { + test {valkey-server command line arguments - wrong usage that we support anyway} { start_server {config "default.conf" args {loglevel verbose "--maxmemory '700mb'" "--maxmemory-policy 'volatile-lru'"}} { assert_match [r config get loglevel] {loglevel verbose} assert_match [r config get maxmemory] {maxmemory 734003200} @@ -688,21 +688,21 @@ start_server {tags {"introspection"}} { } } {} {external:skip} - test {redis-server command line arguments - allow option value to use the `--` prefix} { + test {valkey-server command line arguments - allow option value to use the `--` prefix} { start_server {config "default.conf" args {--proc-title-template --my--title--template --loglevel verbose}} { assert_match [r config get proc-title-template] {proc-title-template --my--title--template} assert_match [r config get loglevel] {loglevel verbose} } } {} {external:skip} - test {redis-server command line arguments - option name and option value in the same arg and `--` prefix} { + test {valkey-server command line arguments - option name and option value in the same arg and `--` prefix} { start_server {config "default.conf" args {"--proc-title-template --my--title--template" "--loglevel verbose"}} { assert_match [r config get proc-title-template] {proc-title-template --my--title--template} assert_match [r config get loglevel] {loglevel verbose} } } {} {external:skip} - test {redis-server command line arguments - save with empty input} { + test {valkey-server command line arguments - save with empty input} { start_server {config "default.conf" args {--save --loglevel verbose}} { assert_match [r config get save] {save {}} assert_match [r config get loglevel] {loglevel verbose} @@ -731,7 +731,7 @@ start_server {tags {"introspection"}} { } {} {external:skip} - test {redis-server command line arguments - take one bulk string with spaces for MULTI_ARG configs parsing} { + test {valkey-server command line arguments - take one bulk string with spaces for MULTI_ARG configs parsing} { start_server {config "default.conf" args {--shutdown-on-sigint nosave force now --shutdown-on-sigterm "nosave force"}} { assert_match [r config get shutdown-on-sigint] {shutdown-on-sigint {nosave now force}} assert_match [r config get shutdown-on-sigterm] {shutdown-on-sigterm {nosave force}} diff --git a/tests/unit/moduleapi/cluster.tcl b/tests/unit/moduleapi/cluster.tcl index 807508387..b4fb02125 100644 --- a/tests/unit/moduleapi/cluster.tcl +++ b/tests/unit/moduleapi/cluster.tcl @@ -43,7 +43,7 @@ start_cluster 3 0 [list config_lines $modules] { test "Perform a Resharding" { - exec src/redis-cli --cluster-yes --cluster reshard 127.0.0.1:[srv -2 port] \ + exec src/valkey-cli --cluster-yes --cluster reshard 127.0.0.1:[srv -2 port] \ --cluster-to [$node1 cluster myid] \ --cluster-from [$node3 cluster myid] \ --cluster-slots 1 @@ -69,9 +69,9 @@ start_cluster 3 0 [list config_lines $modules] { test "Wait for cluster to be stable" { wait_for_condition 1000 50 { - [catch {exec src/redis-cli --cluster check 127.0.0.1:[srv 0 port]}] == 0 && - [catch {exec src/redis-cli --cluster check 127.0.0.1:[srv -1 port]}] == 0 && - [catch {exec src/redis-cli --cluster check 127.0.0.1:[srv -2 port]}] == 0 && + [catch {exec src/valkey-cli --cluster check 127.0.0.1:[srv 0 port]}] == 0 && + [catch {exec src/valkey-cli --cluster check 127.0.0.1:[srv -1 port]}] == 0 && + [catch {exec src/valkey-cli --cluster check 127.0.0.1:[srv -2 port]}] == 0 && [CI 0 cluster_state] eq {ok} && [CI 1 cluster_state] eq {ok} && [CI 2 cluster_state] eq {ok} diff --git a/tests/unit/moduleapi/moduleconfigs.tcl b/tests/unit/moduleapi/moduleconfigs.tcl index 1709e9d99..44f994d2d 100644 --- a/tests/unit/moduleapi/moduleconfigs.tcl +++ b/tests/unit/moduleapi/moduleconfigs.tcl @@ -221,15 +221,15 @@ start_server {tags {"modules"}} { } test {startup moduleconfigs} { # No loadmodule directive - catch {exec src/redis-server --moduleconfigs.string "hello"} err + catch {exec src/valkey-server --moduleconfigs.string "hello"} err assert_match {*Module Configuration detected without loadmodule directive or no ApplyConfig call: aborting*} $err # Bad config value - catch {exec src/redis-server --loadmodule "$testmodule" --moduleconfigs.string "rejectisfreed"} err + catch {exec src/valkey-server --loadmodule "$testmodule" --moduleconfigs.string "rejectisfreed"} err assert_match {*Issue during loading of configuration moduleconfigs.string : Cannot set string to 'rejectisfreed'*} $err # missing LoadConfigs call - catch {exec src/redis-server --loadmodule "$testmodule" noload --moduleconfigs.string "hello"} err + catch {exec src/valkey-server --loadmodule "$testmodule" noload --moduleconfigs.string "hello"} err assert_match {*Module Configurations were not set, likely a missing LoadConfigs call. Unloading the module.*} $err # successful diff --git a/tests/unit/networking.tcl b/tests/unit/networking.tcl index 79d6e399d..4bf981e4a 100644 --- a/tests/unit/networking.tcl +++ b/tests/unit/networking.tcl @@ -122,7 +122,7 @@ start_server {config "minimal.conf" tags {"external:skip"}} { # Make sure bind parameter is as expected and server handles binding # accordingly. # (it seems that rediscli_exec behaves differently in RESP3, possibly - # because CONFIG GET returns a dict instead of a list so redis-cli emits + # because CONFIG GET returns a dict instead of a list so valkey-cli emits # it in a single line) if {$::force_resp3} { assert_equal {{bind }} [rediscli_exec 0 config get bind] diff --git a/tests/unit/other.tcl b/tests/unit/other.tcl index 975e9445a..b9b087cf6 100644 --- a/tests/unit/other.tcl +++ b/tests/unit/other.tcl @@ -401,7 +401,7 @@ start_server {tags {"other external:skip"}} { set cmdline [read_proc_title [srv 0 pid]] assert_equal "TEST" [lindex $cmdline 0] - assert_match "*/redis-server" [lindex $cmdline 1] + assert_match "*/valkey-server" [lindex $cmdline 1] if {$::tls} { set expect_port [srv 0 pport] diff --git a/utils/cluster_fail_time.tcl b/utils/cluster_fail_time.tcl index 87399495f..f488e1831 100644 --- a/utils/cluster_fail_time.tcl +++ b/utils/cluster_fail_time.tcl @@ -15,11 +15,11 @@ proc avg vector { set samples {} while 1 { - exec redis-cli -p $::fail_port debug sleep $::sleep_time > /dev/null & + exec valkey-cli -p $::fail_port debug sleep $::sleep_time > /dev/null & # Wait for fail? to appear. while 1 { - set output [exec redis-cli -p $::other_port cluster nodes] + set output [exec valkey-cli -p $::other_port cluster nodes] if {[string match {*fail\?*} $output]} break after 100 } @@ -29,7 +29,7 @@ while 1 { # Wait for fail? to disappear. while 1 { - set output [exec redis-cli -p $::other_port cluster nodes] + set output [exec valkey-cli -p $::other_port cluster nodes] if {![string match {*fail\?*} $output]} break after 100 } @@ -43,7 +43,7 @@ while 1 { puts "AVG([llength $samples]): [avg $samples]" # Wait for the instance to be available again. - exec redis-cli -p $::fail_port ping + exec valkey-cli -p $::fail_port ping # Wait for the fail flag to be cleared. after 2000 diff --git a/utils/speed-regression.tcl b/utils/speed-regression.tcl index bf35c7db4..f6d523b25 100755 --- a/utils/speed-regression.tcl +++ b/utils/speed-regression.tcl @@ -20,15 +20,15 @@ proc run-tests branches { exec -ignorestderr make 2> /dev/null if {$branch_id == 0} { - puts " copy redis-benchmark from unstable to /tmp..." - exec -ignorestderr cp ./redis-benchmark /tmp + puts " copy valkey-benchmark from unstable to /tmp..." + exec -ignorestderr cp ./valkey-benchmark /tmp incr branch_id continue } # Start the Redis server - puts " starting the server... [exec ./redis-server -v]" - set pids [exec echo "port $::port\nloglevel warning\n" | ./redis-server - > /dev/null 2> /dev/null &] + puts " starting the server... [exec ./valkey-server -v]" + set pids [exec echo "port $::port\nloglevel warning\n" | ./valkey-server - > /dev/null 2> /dev/null &] puts " pids: $pids" after 1000 puts " running the benchmark" @@ -38,7 +38,7 @@ proc run-tests branches { puts " redis INFO shows version: [lindex [split $i] 0]" $r close - set output [exec /tmp/redis-benchmark -n $::requests -t $::tests -d $::datasize --csv -p $::port] + set output [exec /tmp/valkey-benchmark -n $::requests -t $::tests -d $::datasize --csv -p $::port] lappend runs $b $output puts " killing server..." catch {exec kill -9 [lindex $pids 0]} @@ -83,7 +83,7 @@ proc combine-results {results} { } proc main {} { - # Note: the first branch is only used in order to get the redis-benchmark + # Note: the first branch is only used in order to get the valkey-benchmark # executable. Tests are performed starting from the second branch. set branches { slowset 2.2.0 2.4.0 unstable slowset