diff --git a/redis.conf b/redis.conf index 4da7b1696..45cc170dd 100644 --- a/redis.conf +++ b/redis.conf @@ -45,7 +45,7 @@ pidfile /var/run/redis.pid port 6379 # TCP listen() backlog -backlog 511 +tcp-backlog 511 # By default Redis listens for connections from all the network interfaces # available on the server. It is possible to listen to just one or multiple diff --git a/src/config.c b/src/config.c index 6067a63fe..a68e4f3e7 100644 --- a/src/config.c +++ b/src/config.c @@ -127,9 +127,9 @@ void loadServerConfigFromString(char *config) { if (server.port < 0 || server.port > 65535) { err = "Invalid port"; goto loaderr; } - } else if (!strcasecmp(argv[0],"backlog") && argc == 2) { - server.backlog = atoi(argv[1]); - if (server.backlog < 0) { + } else if (!strcasecmp(argv[0],"tcp-backlog") && argc == 2) { + server.tcp_backlog = atoi(argv[1]); + if (server.tcp_backlog < 0) { err = "Invalid backlog value"; goto loaderr; } } else if (!strcasecmp(argv[0],"bind") && argc >= 2) { @@ -980,7 +980,7 @@ void configGetCommand(redisClient *c) { config_get_numerical_field("slowlog-max-len", server.slowlog_max_len); config_get_numerical_field("port",server.port); - config_get_numerical_field("backlog",server.backlog); + config_get_numerical_field("tcp-backlog",server.tcp_backlog); config_get_numerical_field("databases",server.dbnum); config_get_numerical_field("repl-ping-slave-period",server.repl_ping_slave_period); config_get_numerical_field("repl-timeout",server.repl_timeout); @@ -1701,7 +1701,7 @@ int rewriteConfig(char *path) { rewriteConfigYesNoOption(state,"daemonize",server.daemonize,0); rewriteConfigStringOption(state,"pidfile",server.pidfile,REDIS_DEFAULT_PID_FILE); rewriteConfigNumericalOption(state,"port",server.port,REDIS_SERVERPORT); - rewriteConfigNumericalOption(state,"backlog",server.backlog,REDIS_BACKLOG); + rewriteConfigNumericalOption(state,"tcp-backlog",server.tcp_backlog,REDIS_TCP_BACKLOG); rewriteConfigBindOption(state); rewriteConfigStringOption(state,"unixsocket",server.unixsocket,NULL); rewriteConfigOctalOption(state,"unixsocketperm",server.unixsocketperm,REDIS_DEFAULT_UNIX_SOCKET_PERM); diff --git a/src/redis.c b/src/redis.c index 80b80dd16..b3f6dd867 100644 --- a/src/redis.c +++ b/src/redis.c @@ -1332,7 +1332,7 @@ void initServerConfig() { server.runid[REDIS_RUN_ID_SIZE] = '\0'; server.arch_bits = (sizeof(long) == 8) ? 64 : 32; server.port = REDIS_SERVERPORT; - server.backlog = REDIS_BACKLOG; + server.tcp_backlog = REDIS_TCP_BACKLOG; server.bindaddr_count = 0; server.unixsocket = NULL; server.unixsocketperm = REDIS_DEFAULT_UNIX_SOCKET_PERM; @@ -1541,9 +1541,11 @@ int listenToPort(int port, int *fds, int *count) { if (server.bindaddr[j] == NULL) { /* Bind * for both IPv6 and IPv4, we enter here only if * server.bindaddr_count == 0. */ - fds[*count] = anetTcp6Server(server.neterr,port,NULL, server.backlog); + fds[*count] = anetTcp6Server(server.neterr,port,NULL, + server.tcp_backlog); if (fds[*count] != ANET_ERR) (*count)++; - fds[*count] = anetTcpServer(server.neterr,port,NULL, server.backlog); + fds[*count] = anetTcpServer(server.neterr,port,NULL, + server.tcp_backlog); if (fds[*count] != ANET_ERR) (*count)++; /* Exit the loop if we were able to bind * on IPv4 or IPv6, * otherwise fds[*count] will be ANET_ERR and we'll print an @@ -1551,10 +1553,12 @@ int listenToPort(int port, int *fds, int *count) { if (*count) break; } else if (strchr(server.bindaddr[j],':')) { /* Bind IPv6 address. */ - fds[*count] = anetTcp6Server(server.neterr,port,server.bindaddr[j], server.backlog); + fds[*count] = anetTcp6Server(server.neterr,port,server.bindaddr[j], + server.tcp_backlog); } else { /* Bind IPv4 address. */ - fds[*count] = anetTcpServer(server.neterr,port,server.bindaddr[j], server.backlog); + fds[*count] = anetTcpServer(server.neterr,port,server.bindaddr[j], + server.tcp_backlog); } if (fds[*count] == ANET_ERR) { redisLog(REDIS_WARNING, @@ -1604,7 +1608,8 @@ void initServer() { /* Open the listening Unix domain socket. */ if (server.unixsocket != NULL) { unlink(server.unixsocket); /* don't care if this fails */ - server.sofd = anetUnixServer(server.neterr,server.unixsocket,server.unixsocketperm, server.backlog); + server.sofd = anetUnixServer(server.neterr,server.unixsocket, + server.unixsocketperm, server.tcp_backlog); if (server.sofd == ANET_ERR) { redisLog(REDIS_WARNING, "Opening socket: %s", server.neterr); exit(1); diff --git a/src/redis.h b/src/redis.h index fe9c85c67..e8008b57f 100644 --- a/src/redis.h +++ b/src/redis.h @@ -71,7 +71,7 @@ #define REDIS_MIN_HZ 1 #define REDIS_MAX_HZ 500 #define REDIS_SERVERPORT 6379 /* TCP port */ -#define REDIS_BACKLOG 511 /* TCP listen backlog */ +#define REDIS_TCP_BACKLOG 511 /* TCP listen backlog */ #define REDIS_MAXIDLETIME 0 /* default client timeout: infinite */ #define REDIS_DEFAULT_DBNUM 16 #define REDIS_CONFIGLINE_MAX 1024 @@ -609,7 +609,7 @@ struct redisServer { int sentinel_mode; /* True if this instance is a Sentinel. */ /* Networking */ int port; /* TCP listening port */ - int backlog; /* TCP listen backlog */ + int tcp_backlog; /* TCP listen() backlog */ char *bindaddr[REDIS_BINDADDR_MAX]; /* Addresses we should bind to */ int bindaddr_count; /* Number of addresses in server.bindaddr[] */ char *unixsocket; /* UNIX socket path */