From 7ba7e4d05365a9f5374120838b26c99b8f129d08 Mon Sep 17 00:00:00 2001 From: Shivshankar Date: Tue, 28 May 2024 13:36:54 -0400 Subject: [PATCH] Update zfree on data in test_crc64combine before return. (#548) Signed-off-by: Shivshankar-Reddy Signed-off-by: Madelyn Olson Co-authored-by: Madelyn Olson --- src/unit/test_crc64combine.c | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/src/unit/test_crc64combine.c b/src/unit/test_crc64combine.c index 67ef4ade4..ba5c29a42 100644 --- a/src/unit/test_crc64combine.c +++ b/src/unit/test_crc64combine.c @@ -135,19 +135,35 @@ again: /* get the single-character version for single-byte Redis behavior */ set_crc64_cutoffs(0, crc64_test_size + 1); - if (bench_crc64(data, crc64_test_size, passes, expect, "crc_1byte", csv)) return 1; + if (bench_crc64(data, crc64_test_size, passes, expect, "crc_1byte", csv)) { + zfree(data); + data = NULL; + return 1; + } set_crc64_cutoffs(crc64_test_size + 1, crc64_test_size + 1); /* run with 8-byte "single" path, crcfaster */ - if (bench_crc64(data, crc64_test_size, passes, expect, "crcspeed", csv)) return 1; + if (bench_crc64(data, crc64_test_size, passes, expect, "crcspeed", csv)) { + zfree(data); + data = NULL; + return 1; + } /* run with dual 8-byte paths */ set_crc64_cutoffs(1, crc64_test_size + 1); - if (bench_crc64(data, crc64_test_size, passes, expect, "crcdual", csv)) return 1; + if (bench_crc64(data, crc64_test_size, passes, expect, "crcdual", csv)) { + zfree(data); + data = NULL; + return 1; + } /* run with tri 8-byte paths */ set_crc64_cutoffs(1, 1); - if (bench_crc64(data, crc64_test_size, passes, expect, "crctri", csv)) return 1; + if (bench_crc64(data, crc64_test_size, passes, expect, "crctri", csv)) { + zfree(data); + data = NULL; + return 1; + } /* Be free memory region, be free. */ zfree(data);