From 7778f1b4b03a6a416388fe28d9bc93374384a65b Mon Sep 17 00:00:00 2001 From: Oran Agra Date: Wed, 10 Mar 2021 15:25:16 +0200 Subject: [PATCH] strip % sign from current_fork_perc info field (#8628) `master_sync_perc` and `loading_loaded_perc` don't have that sign, and i think the info field should be a raw floating point number (the name suggests its units). we already have `used_memory_peak_perc` and `used_memory_dataset_perc` which do add the `%` sign, but: 1) i think it was a mistake but maybe too late to fix now, and maybe not too late to fix for `current_fork_perc` 2) it is more important to be consistent with the two other "progress" "prec" metrics, and not with the "utilization" metric. --- src/server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server.c b/src/server.c index e7c9787b1..81e23d8ee 100644 --- a/src/server.c +++ b/src/server.c @@ -4801,7 +4801,7 @@ sds genRedisInfoString(const char *section) { "# Persistence\r\n" "loading:%d\r\n" "current_cow_size:%zu\r\n" - "current_fork_perc:%.2f%%\r\n" + "current_fork_perc:%.2f\r\n" "current_save_keys_processed:%zu\r\n" "current_save_keys_total:%zu\r\n" "rdb_changes_since_last_save:%lld\r\n"