gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

tracking pending invalidation message of flushdb sent by (#11068)

Browse Source 
trackingHandlePendingKeyInvalidations should use proto.
This commit is contained in:
Huang Zhw 2022-07-31 21:14:39 +08:00 committed by GitHub
parent 90f35cea81
commit 61451b02cb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/tracking.c
View File

@ -423,9 +423,15 @@ void trackingHandlePendingKeyInvalidations() {
robj *key = listNodeValue(ln);
/* current_client maybe freed, so we need to send invalidation
* message only when current_client is still alive */
if (server.current_client != NULL)
sendTrackingMessage(server.current_client,(char *)key->ptr,sdslen(key->ptr),0);
decrRefCount(key);
if (server.current_client != NULL) {
if (key != NULL) {
sendTrackingMessage(server.current_client,(char *)key->ptr,sdslen(key->ptr),0);
} else {
sendTrackingMessage(server.current_client,shared.null[server.current_client->resp]->ptr,
sdslen(shared.null[server.current_client->resp]->ptr),1);
}
}
if (key != NULL) decrRefCount(key);
}
listEmpty(server.tracking_pending_keys);
}
@ -455,8 +461,8 @@ void trackingInvalidateKeysOnFlush(int async) {
client *c = listNodeValue(ln);
if (c->flags & CLIENT_TRACKING) {
if (c == server.current_client) {
incrRefCount(shared.null[c->resp]);
listAddNodeTail(server.tracking_pending_keys,shared.null[c->resp]);
/* We use a special NULL to indicate that we should send null */
listAddNodeTail(server.tracking_pending_keys,NULL);
} else {
sendTrackingMessage(c,shared.null[c->resp]->ptr,sdslen(shared.null[c->resp]->ptr),1);
}

2
tests/unit/tracking.tcl
View File

@ -560,7 +560,7 @@ start_server {tags {"tracking network"}} {
assert_equal $res {OK}
# Consume the invalidate message which is after command response
r read
} {invalidate *_*}
} {invalidate {}}
# Keys are defined to be evicted 100 at a time by default.
# If after eviction the number of keys still surpasses the limit