gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix misleading module test (#8366)

Browse Source 
the test was misleading because the module would actually woke up on a wrong type and
re-blocked, while the test name suggests the module doesn't not wake up at all on a wrong type..

i changed the name of the test + added verification that indeed the module wakes up and gets
re-blocked after it understand it's the wrong type
This commit is contained in:
guybe7 2021-01-20 13:03:38 +01:00 committed by GitHub
parent baf92f3f1c
commit 5a77d015be
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tests/modules/blockonkeys.c
View File

@ -65,6 +65,7 @@ int get_fsl(RedisModuleCtx *ctx, RedisModuleString *keyname, int mode, int creat
RedisModule_CloseKey(key); RedisModule_CloseKey(key);
if (reply_on_failure) if (reply_on_failure)
RedisModule_ReplyWithError(ctx, REDISMODULE_ERRORMSG_WRONGTYPE); RedisModule_ReplyWithError(ctx, REDISMODULE_ERRORMSG_WRONGTYPE);
RedisModule_Call(ctx, "INCR", "c", "fsl_wrong_type");
return 0; return 0;
} }

3
tests/unit/moduleapi/blockonkeys.tcl
View File

@ -168,7 +168,7 @@ start_server {tags {"modules"}} {
assert_error "*unblocked*" {$rd read} assert_error "*unblocked*" {$rd read}
} }
test {Module client blocked on keys does not wake up on wrong type} { test {Module client re-blocked on keys after woke up on wrong type} {
r del k r del k
set rd [redis_deferring_client] set rd [redis_deferring_client]
$rd fsl.bpop k 0 $rd fsl.bpop k 0
@ -184,6 +184,7 @@ start_server {tags {"modules"}} {
r del k r del k
r fsl.push k 34 r fsl.push k 34
assert_equal {34} [$rd read] assert_equal {34} [$rd read]
assert_equal {1} [r get fsl_wrong_type] ;# first lpush caused one wrong-type wake-up
} }
test {Module client blocked on keys woken up by LPUSH} { test {Module client blocked on keys woken up by LPUSH} {