gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix redundancy incrRefCount in lmoveGenericCommand (#8218)

Browse Source
This commit is contained in:
sundb 2020-12-24 00:37:33 +08:00 committed by GitHub
parent ee59dc1b5c
commit 58e9c26115
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/t_list.c
View File

@ -729,10 +729,6 @@ void lmoveGenericCommand(client *c, int wherefrom, int whereto) {
if (checkType(c,dobj,OBJ_LIST)) return; if (checkType(c,dobj,OBJ_LIST)) return;
value = listTypePop(sobj,wherefrom); value = listTypePop(sobj,wherefrom);
serverAssert(value); /* assertion for valgrind (avoid NPD) */ serverAssert(value); /* assertion for valgrind (avoid NPD) */
/* We saved touched key, and protect it, since lmoveHandlePush
* may change the client command argument vector (it does not
* currently). */
incrRefCount(touchedkey);
lmoveHandlePush(c,c->argv[2],dobj,value,whereto); lmoveHandlePush(c,c->argv[2],dobj,value,whereto);
/* listTypePop returns an object with its refcount incremented */ /* listTypePop returns an object with its refcount incremented */
@ -749,7 +745,6 @@ void lmoveGenericCommand(client *c, int wherefrom, int whereto) {
touchedkey,c->db->id); touchedkey,c->db->id);
} }
signalModifiedKey(c,c->db,touchedkey); signalModifiedKey(c,c->db,touchedkey);
decrRefCount(touchedkey);
server.dirty++; server.dirty++;
if (c->cmd->proc == blmoveCommand) { if (c->cmd->proc == blmoveCommand) {
rewriteClientCommandVector(c,5,shared.lmove, rewriteClientCommandVector(c,5,shared.lmove,