gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

deflake client-eviction test "evict clients only until below limit" (#10354)

Browse Source 
After introducing #9822 need to prevent client reply buffer shrink
to maintain correct client memory math.

add needs:debug missing one one test.

Co-authored-by: Oran Agra <oran@redislabs.com>
This commit is contained in:
ranshid 2022-02-28 11:32:42 +02:00 committed by GitHub
parent fa5d90069f
commit 5860fa3d9c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/unit/client-eviction.tcl
View File

@ -217,7 +217,7 @@ start_server {} {
r debug pause-cron 0 r debug pause-cron 0
$rr close $rr close
$redirected_c close $redirected_c close
} } {0} {needs:debug}
test "client evicted due to client tracking prefixes" { test "client evicted due to client tracking prefixes" {
r flushdb r flushdb
@ -395,6 +395,7 @@ start_server {} {
test "evict clients only until below limit" { test "evict clients only until below limit" {
set client_count 10 set client_count 10
set client_mem [mb 1] set client_mem [mb 1]
r debug replybuffer-peak-reset-time never
r config set maxmemory-clients 0 r config set maxmemory-clients 0
r client setname control r client setname control
r client no-evict on r client no-evict on
@ -437,8 +438,11 @@ start_server {} {
set connected_clients [llength [lsearch -all [split [string trim [r client list]] "\r\n"] *name=client*]] set connected_clients [llength [lsearch -all [split [string trim [r client list]] "\r\n"] *name=client*]]
assert {$connected_clients == [expr $client_count / 2]} assert {$connected_clients == [expr $client_count / 2]}
# Restore the peak reset time to default
r debug replybuffer-peak-reset-time reset
foreach rr $rrs {$rr close} foreach rr $rrs {$rr close}
} } {} {needs:debug}
} }
start_server {} { start_server {} {