gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions 8 Packages Projects Releases Wiki Activity

Fix the wrong method used in quicklistTest. (#8951)

Browse Source 
The test try to test `insert before 1 element`, but it use quicklist
InsertAfter, a copy-paste typo.

The commit also add an assert to verify results in some tests
to make sure it is as expected.
This commit is contained in:
Binbin 2021-08-08 14:03:52 +08:00 committed by GitHub
parent 43eb0ce3bf
commit 563ba7a3f0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 41 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
src/quicklist.c
View File

@ -1976,6 +1976,13 @@ int quicklistTest(int argc, char *argv[], int accurate) {
quicklistIndex(ql, 0, &entry);
quicklistInsertBefore(ql, &entry, "abc", 4);
ql_verify(ql, 1, 1, 1, 1);
/* verify results */
quicklistIndex(ql, 0, &entry);
if (strncmp((char *)entry.value, "abc", 3)) {
ERR("Value 0 didn't match, instead got: %.*s", entry.sz,
entry.value);
}
quicklistRelease(ql);
}
@ -1985,6 +1992,13 @@ int quicklistTest(int argc, char *argv[], int accurate) {
quicklistIndex(ql, 0, &entry);
quicklistInsertAfter(ql, &entry, "abc", 4);
ql_verify(ql, 1, 1, 1, 1);
/* verify results */
quicklistIndex(ql, 0, &entry);
if (strncmp((char *)entry.value, "abc", 3)) {
ERR("Value 0 didn't match, instead got: %.*s", entry.sz,
entry.value);
}
quicklistRelease(ql);
}
@ -1995,6 +2009,19 @@ int quicklistTest(int argc, char *argv[], int accurate) {
quicklistIndex(ql, 0, &entry);
quicklistInsertAfter(ql, &entry, "abc", 4);
ql_verify(ql, 1, 2, 2, 2);
/* verify results */
quicklistIndex(ql, 0, &entry);
if (strncmp((char *)entry.value, "hello", 5)) {
ERR("Value 0 didn't match, instead got: %.*s", entry.sz,
entry.value);
}
quicklistIndex(ql, 1, &entry);
if (strncmp((char *)entry.value, "abc", 3)) {
ERR("Value 1 didn't match, instead got: %.*s", entry.sz,
entry.value);
}
quicklistRelease(ql);
}
@ -2003,8 +2030,21 @@ int quicklistTest(int argc, char *argv[], int accurate) {
quicklistPushHead(ql, "hello", 6);
quicklistEntry entry;
quicklistIndex(ql, 0, &entry);
quicklistInsertAfter(ql, &entry, "abc", 4);
quicklistInsertBefore(ql, &entry, "abc", 4);
ql_verify(ql, 1, 2, 2, 2);
/* verify results */
quicklistIndex(ql, 0, &entry);
if (strncmp((char *)entry.value, "abc", 3)) {
ERR("Value 0 didn't match, instead got: %.*s", entry.sz,
entry.value);
}
quicklistIndex(ql, 1, &entry);
if (strncmp((char *)entry.value, "hello", 5)) {
ERR("Value 1 didn't match, instead got: %.*s", entry.sz,
entry.value);
}
quicklistRelease(ql);
}