From 4ba144a4eb26572caecfa080401a5e8a01d5763d Mon Sep 17 00:00:00 2001 From: Binbin Date: Fri, 1 Sep 2023 19:15:11 +0800 Subject: [PATCH] Add logreqres:skip flag to new INFO obuf limit test (#12537) The new test added in #12476 causes reply-schemas-validator to fail. When doing `catch {r get key}`, the req-res output is: ``` 3 get 3 key 12 __argv_end__ $100000 aaaaaaaaaaaaaaaaaaaa...4 info 5 stats 12 __argv_end__ =1670 txt:# Stats ... ``` And we can see the link after `$100000`, there is a 4 in the last, it break the req-res-log-validator script since the format is wrong. The reason i guess is after the client reconnection (after the output buf limit), we will not add newlines, but append args directly. Since obuf-limits.tcl is doing the same thing, and it had the logreqres:skip flag, so this PR is following it. --- tests/unit/info.tcl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/info.tcl b/tests/unit/info.tcl index ae3f82699..aeadbee7f 100644 --- a/tests/unit/info.tcl +++ b/tests/unit/info.tcl @@ -362,6 +362,6 @@ start_server {tags {"info" "external:skip"}} { set info [r info stats] assert_equal [getInfoProperty $info client_output_buffer_limit_disconnections] {1} r config set client-output-buffer-limit $org_outbuf_limit - } + } {OK} {logreqres:skip} ;# same as obuf-limits.tcl, skip logreqres } }