gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

ACL: remove leak when removing passwords/patterns.

Browse Source
This commit is contained in:
antirez 2019-01-28 12:11:11 +01:00
parent 6cec82b943
commit 4b9b128c49
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/acl.c
View File

@ -134,6 +134,11 @@ int ACLListMatchSds(void *a, void *b) {
return sdscmp(a,b) == 0; return sdscmp(a,b) == 0;
} }
/* Method to free list elements from ACL users password/ptterns lists. */
void ACLListFreeSds(void *item) {
sdsfree(item);
}
/* Create a new user with the specified name, store it in the list /* Create a new user with the specified name, store it in the list
* of users (the Users global radix tree), and returns a reference to * of users (the Users global radix tree), and returns a reference to
* the structure representing the user. * the structure representing the user.
@ -148,7 +153,9 @@ user *ACLCreateUser(const char *name, size_t namelen) {
u->passwords = listCreate(); u->passwords = listCreate();
u->patterns = listCreate(); u->patterns = listCreate();
listSetMatchMethod(u->passwords,ACLListMatchSds); listSetMatchMethod(u->passwords,ACLListMatchSds);
listSetFreeMethod(u->passwords,ACLListFreeSds);
listSetMatchMethod(u->patterns,ACLListMatchSds); listSetMatchMethod(u->patterns,ACLListMatchSds);
listSetFreeMethod(u->patterns,ACLListFreeSds);
memset(u->allowed_commands,0,sizeof(u->allowed_commands)); memset(u->allowed_commands,0,sizeof(u->allowed_commands));
raxInsert(Users,(unsigned char*)name,namelen,u,NULL); raxInsert(Users,(unsigned char*)name,namelen,u,NULL);
return u; return u;