gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions 8 Packages Projects Releases Wiki Activity

Update replica version comparison to handle version 8 RC candidates (#851)

Browse Source 
Release candidates have a version that is lower than 8.0.0 to allow for
8.0.0 to have 0x080000 as a release number. However, we did an explicit
check to make sure a version was 8.0 or greater to validate a replica
supports a feature. Now we are using the highest patch version of latest
minor to do the comparison to accommodate future versions.

Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
This commit is contained in:
Madelyn Olson 2024-07-31 10:01:48 -07:00 committed by GitHub
parent 1d18842074
commit 4b8de6b1be
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/cluster_legacy.c
View File

@ -6284,7 +6284,7 @@ void clusterCommandSetSlot(client *c) {
* the process. */ * the process. */
if (nodeIsPrimary(myself) && myself->num_replicas != 0 && !c->flag.replication_done) { if (nodeIsPrimary(myself) && myself->num_replicas != 0 && !c->flag.replication_done) {
/* Iterate through the list of replicas to check if there are any running /* Iterate through the list of replicas to check if there are any running
* a version older than 8.0.0. Replicas with versions older than 8.0.0 do * version 7.2 or older. Replicas running on these versions do
* not support the CLUSTER SETSLOT command on replicas. If such a replica * not support the CLUSTER SETSLOT command on replicas. If such a replica
* is found, we should skip the replication and fall back to the old * is found, we should skip the replication and fall back to the old
* non-replicated behavior.*/ * non-replicated behavior.*/
@ -6294,7 +6294,7 @@ void clusterCommandSetSlot(client *c) {
listRewind(server.replicas, &li); listRewind(server.replicas, &li);
while ((ln = listNext(&li))) { while ((ln = listNext(&li))) {
client *r = ln->value; client *r = ln->value;
if (r->replica_version < 0x80000 /* 8.0.0 */) { if (r->replica_version < 0x702ff /* 7.2.255 */) {
legacy_replica_found++; legacy_replica_found++;
break; break;
} }