From 3cc619f6378e46b005604e9e24c75f948a7322db Mon Sep 17 00:00:00 2001 From: Ping Xie Date: Fri, 13 Sep 2024 00:02:39 -0700 Subject: [PATCH] Disable flaky empty shard slot migration tests (#1027) Will continue my investigation offline Signed-off-by: Ping Xie --- tests/unit/cluster/slot-migration.tcl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/unit/cluster/slot-migration.tcl b/tests/unit/cluster/slot-migration.tcl index c117e8304..d79897196 100644 --- a/tests/unit/cluster/slot-migration.tcl +++ b/tests/unit/cluster/slot-migration.tcl @@ -218,6 +218,7 @@ proc create_empty_shard {p r} { # Temporarily disable empty shard migration tests while we # work to reduce their flakiness. See https://github.com/valkey-io/valkey/issues/858. +if {0} { start_cluster 3 5 {tags {external:skip cluster} overrides {cluster-allow-replica-migration no cluster-node-timeout 1000} } { set node_timeout [lindex [R 0 CONFIG GET cluster-node-timeout] 1] @@ -294,6 +295,7 @@ start_cluster 3 5 {tags {external:skip cluster} overrides {cluster-allow-replica wait_for_slot_state 7 "\[609-<-$R0_id\]" } } +} proc migrate_slot {from to slot} { set from_id [R $from CLUSTER MYID]