gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

hllSparseAdd(): more correct dense conversion conditional.

Browse Source 
We want to promote if the total string size exceeds the resulting size
after the upgrade.
This commit is contained in:
antirez 2014-04-14 09:36:27 +02:00
parent b7571b7453
commit 3b20003503
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/hyperloglog.c
View File

@ -801,7 +801,7 @@ int hllSparseAdd(robj *o, unsigned char *ele, size_t elesize) {
int oldlen = is_xzero ? 2 : 1; int oldlen = is_xzero ? 2 : 1;
int deltalen = seqlen-oldlen; int deltalen = seqlen-oldlen;
if (deltalen > 0 && sdslen(o->ptr) > HLL_SPARSE_MAX) goto promote; if (deltalen > 0 && sdslen(o->ptr)+deltalen > HLL_SPARSE_MAX) goto promote;
if (deltalen && next) memmove(next+deltalen,next,next-sparse); if (deltalen && next) memmove(next+deltalen,next,next-sparse);
sdsIncrLen(o->ptr,deltalen); sdsIncrLen(o->ptr,deltalen);
memcpy(p,seq,seqlen); memcpy(p,seq,seqlen);