From 38ed6c600791f266cea1ba66f53674c605b7babb Mon Sep 17 00:00:00 2001
From: DarrenJiang13 <yjjiang1996@163.com>
Date: Mon, 14 Mar 2022 14:22:57 +0800
Subject: [PATCH] improve string2ll() to avoid extra conversion for long
 integer string. (#10408)

For an integer string like "123456789012345678901" which could cause
overflow-failure in string2ll() conversion, we could compare its length at
the beginning to avoid extra work.

* move LONG_STR_SIZE to be in declared in util.h, next to MAX_LONG_DOUBLE_CHARS
---
 src/server.h | 1 -
 src/util.c   | 4 ++--
 src/util.h   | 3 +++
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/server.h b/src/server.h
index 92ca57229..26c10170a 100644
--- a/src/server.h
+++ b/src/server.h
@@ -165,7 +165,6 @@ typedef long long ustime_t; /* microsecond time type. */
 #define PROTO_MBULK_BIG_ARG     (1024*32)
 #define PROTO_RESIZE_THRESHOLD  (1024*32) /* Threshold for determining whether to resize query buffer */
 #define PROTO_REPLY_MIN_BYTES   (1024) /* the lower limit on reply buffer size */
-#define LONG_STR_SIZE      21          /* Bytes needed for long -> str + '\0' */
 #define REDIS_AUTOSYNC_BYTES (1024*1024*4) /* Sync file every 4MB. */
 
 #define LIMIT_PENDING_QUERYBUF (4*1024*1024) /* 4mb */
diff --git a/src/util.c b/src/util.c
index 75086db42..45591d9f2 100644
--- a/src/util.c
+++ b/src/util.c
@@ -405,8 +405,8 @@ int string2ll(const char *s, size_t slen, long long *value) {
     int negative = 0;
     unsigned long long v;
 
-    /* A zero length string is not a valid number. */
-    if (plen == slen)
+    /* A string of zero length or excessive length is not a valid number. */
+    if (plen == slen || slen >= LONG_STR_SIZE)
         return 0;
 
     /* Special case: first and only digit is 0. */
diff --git a/src/util.h b/src/util.h
index 7dce8ff69..c81db5d16 100644
--- a/src/util.h
+++ b/src/util.h
@@ -38,6 +38,9 @@
  * This should be the size of the buffer given to ld2string */
 #define MAX_LONG_DOUBLE_CHARS 5*1024
 
+/* Bytes needed for long -> str + '\0' */
+#define LONG_STR_SIZE      21
+
 /* long double to string conversion options */
 typedef enum {
     LD_STR_AUTO,     /* %.17Lg */