From 36e54e93b78eba63c35d699c6e96d6ca2a9907fd Mon Sep 17 00:00:00 2001 From: filipe oliveira Date: Mon, 8 Feb 2021 14:24:00 +0000 Subject: [PATCH] [fix] Increasing block on background timeout time to avoid test failure (#8470) The test failed from time to time on Github actions. We think it's possible that on the module's blocking timeout time tracking test, the timeout is happening prior we issue the RedisModule_BlockedClientMeasureTimeStart(bc) on the background thread. If that is the case one possible solution is to increase the timeout. Increasing to 200ms to 500ms to see if nightly stops failing. --- tests/unit/moduleapi/blockonbackground.tcl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/unit/moduleapi/blockonbackground.tcl b/tests/unit/moduleapi/blockonbackground.tcl index 23111ab73..46a72bfd2 100644 --- a/tests/unit/moduleapi/blockonbackground.tcl +++ b/tests/unit/moduleapi/blockonbackground.tcl @@ -29,14 +29,14 @@ start_server {tags {"modules"}} { r block.debug 0 20000 assert_equal [r slowlog len] 0 r config resetstat - r block.debug 20000 200 + r block.debug 20000 500 assert_equal [r slowlog len] 1 set cmdstatline [cmdrstat block.debug r] regexp "calls=1,usec=(.*?),usec_per_call=(.*?),rejected_calls=0,failed_calls=0" $cmdstatline usec usec_per_call - assert {$usec >= 100000} - assert {$usec_per_call >= 100000} + assert {$usec >= 250000} + assert {$usec_per_call >= 250000} } test { blocked clients time tracking - check blocked command with multiple calls RedisModule_BlockedClientMeasureTimeStart() is tracking the total background time } {