From 324e22accf457edc996971bc97f5474349cd7c4c Mon Sep 17 00:00:00 2001
From: antirez <antirez@gmail.com>
Date: Fri, 20 Dec 2019 12:29:02 +0100
Subject: [PATCH] Fix ip and missing mode in RM_GetClusterNodeInfo().
---
src/module.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/module.c b/src/module.c
index 33b69f8c2..705ffec2c 100644
--- a/src/module.c
+++ b/src/module.c
@@ -5082,10 +5082,13 @@ int RM_GetClusterNodeInfo(RedisModuleCtx *ctx, const char *id, char *ip, char *m
UNUSED(ctx);
clusterNode *node = clusterLookupNode(id);
- if (node->flags & (CLUSTER_NODE_NOADDR|CLUSTER_NODE_HANDSHAKE))
+ if (node == NULL ||
+ node->flags & (CLUSTER_NODE_NOADDR|CLUSTER_NODE_HANDSHAKE))
+ {
return REDISMODULE_ERR;
+ }
- if (ip) memcpy(ip,node->name,REDISMODULE_NODE_ID_LEN);
+ if (ip) strncpy(ip,node->ip,NET_IP_STR_LEN);
if (master_id) {
/* If the information is not available, the function will set the