From 30775bc3e3a919e6a168523e772551332738e9f3 Mon Sep 17 00:00:00 2001 From: Oran Agra Date: Mon, 15 Feb 2021 12:50:23 +0200 Subject: [PATCH] solve race in replication-2 test - again (#8491) this should make it timing independent and also faster in most cases --- tests/integration/replication-2.tcl | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/integration/replication-2.tcl b/tests/integration/replication-2.tcl index fc67e78c1..9524f3563 100644 --- a/tests/integration/replication-2.tcl +++ b/tests/integration/replication-2.tcl @@ -43,10 +43,14 @@ start_server {tags {"repl"}} { r config set min-slaves-max-lag 2 exec kill -SIGSTOP [srv -1 pid] assert {[r set foo 12345] eq {OK}} - after 4000 + wait_for_condition 100 100 { + [catch {r set foo 12345}] != 0 + } else { + fail "Master didn't become readonly" + } catch {r set foo 12345} err - set err - } {NOREPLICAS*} + assert_match {NOREPLICAS*} $err + } exec kill -SIGCONT [srv -1 pid] test {min-slaves-to-write is ignored by slaves} {