From 2ed300b78658f79a97ca2af4ef25643617ff9c49 Mon Sep 17 00:00:00 2001 From: antirez Date: Wed, 29 Jan 2020 12:47:50 +0100 Subject: [PATCH] Add more info in the unblockClientFromModule() function. --- src/module.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/module.c b/src/module.c index d2b267be2..7fdab1b34 100644 --- a/src/module.c +++ b/src/module.c @@ -4282,7 +4282,13 @@ void unblockClientFromModule(client *c) { * not implemented (or it was, but RM_UnblockClient was not called from * within it, as it should). * We must call moduleUnblockClient in order to free privdata and - * RedisModuleBlockedClient */ + * RedisModuleBlockedClient. + * + * Note that clients implementing threads and working with private data, + * should make sure to stop the threads or protect the private data + * in some other way in the disconnection and timeout callback, because + * here we are going to free the private data associated with the + * blocked client. */ if (!bc->unblocked) moduleUnblockClient(c);