gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix active rep not merging on sync and add tests

Browse Source 
Former-commit-id: fcb77d0431b195553eb1cd563286e5441f0c94cd
This commit is contained in:
John Sully 2020-01-29 13:26:04 -05:00
parent dc4d3a607f
commit 2e84764f1b
2 changed files with 59 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
src/replication.cpp
View File

@ -1872,17 +1872,21 @@ void readSyncBulkPayload(connection *conn) {
/* We need to stop any AOF rewriting child before flusing and parsing /* We need to stop any AOF rewriting child before flusing and parsing
* the RDB, otherwise we'll create a copy-on-write disaster. */ * the RDB, otherwise we'll create a copy-on-write disaster. */
if (g_pserver->aof_state != AOF_OFF) stopAppendOnly(); if (g_pserver->aof_state != AOF_OFF) stopAppendOnly();
signalFlushedDb(-1);
/* When diskless RDB loading is used by replicas, it may be configured if (!fUpdate)
* in order to save the current DB instead of throwing it away,
* so that we can restore it in case of failed transfer. */
if (use_diskless_load &&
g_pserver->repl_diskless_load == REPL_DISKLESS_LOAD_SWAPDB)
{ {
diskless_load_backup = disklessLoadMakeBackups(); signalFlushedDb(-1);
} else {
emptyDb(-1,empty_db_flags,replicationEmptyDbCallback); /* When diskless RDB loading is used by replicas, it may be configured
* in order to save the current DB instead of throwing it away,
* so that we can restore it in case of failed transfer. */
if (use_diskless_load &&
g_pserver->repl_diskless_load == REPL_DISKLESS_LOAD_SWAPDB)
{
diskless_load_backup = disklessLoadMakeBackups();
} else {
emptyDb(-1,empty_db_flags,replicationEmptyDbCallback);
}
} }
/* Before loading the DB into memory we need to delete the readable /* Before loading the DB into memory we need to delete the readable
@ -1910,14 +1914,16 @@ void readSyncBulkPayload(connection *conn) {
"from socket"); "from socket");
cancelReplicationHandshake(mi); cancelReplicationHandshake(mi);
rioFreeConn(&rdb, NULL); rioFreeConn(&rdb, NULL);
if (g_pserver->repl_diskless_load == REPL_DISKLESS_LOAD_SWAPDB) { if (!fUpdate) {
/* Restore the backed up databases. */ if (g_pserver->repl_diskless_load == REPL_DISKLESS_LOAD_SWAPDB) {
disklessLoadRestoreBackups(diskless_load_backup,1, /* Restore the backed up databases. */
empty_db_flags); disklessLoadRestoreBackups(diskless_load_backup,1,
} else { empty_db_flags);
/* Remove the half-loaded data in case we started with } else {
* an empty replica. */ /* Remove the half-loaded data in case we started with
emptyDb(-1,empty_db_flags,replicationEmptyDbCallback); * an empty replica. */
emptyDb(-1,empty_db_flags,replicationEmptyDbCallback);
}
} }
/* Note that there's no point in restarting the AOF on SYNC /* Note that there's no point in restarting the AOF on SYNC
@ -1927,12 +1933,14 @@ void readSyncBulkPayload(connection *conn) {
} }
stopLoading(1); stopLoading(1);
/* RDB loading succeeded if we reach this point. */ if (!fUpdate) {
if (g_pserver->repl_diskless_load == REPL_DISKLESS_LOAD_SWAPDB) { /* RDB loading succeeded if we reach this point. */
/* Delete the backup databases we created before starting to load if (g_pserver->repl_diskless_load == REPL_DISKLESS_LOAD_SWAPDB) {
* the new RDB. Now the RDB was loaded with success so the old /* Delete the backup databases we created before starting to load
* data is useless. */ * the new RDB. Now the RDB was loaded with success so the old
disklessLoadRestoreBackups(diskless_load_backup,0,empty_db_flags); * data is useless. */
disklessLoadRestoreBackups(diskless_load_backup,0,empty_db_flags);
}
} }
/* Verify the end mark is correct. */ /* Verify the end mark is correct. */

28
tests/integration/replication-active.tcl
View File

@ -129,3 +129,31 @@ start_server {tags {"active-repl"} overrides {active-replica yes}} {
} }
} }
} }
foreach mdl {no yes} {
foreach sdl {disabled swapdb} {
start_server {tags {"active-repl"} overrides {active-replica yes}} {
set master [srv 0 client]
$master config set repl-diskless-sync $mdl
set master_host [srv 0 host]
set master_port [srv 0 port]
r set masterkey foo
start_server {overrides {active-replica yes}} {
test "Active replication databases are merged, master diskless=$mdl, replica diskless=$sdl" {
r config set repl-diskless-load $sdl
r set slavekey bar
r replicaof $master_host $master_port
wait_for_condition 50 400 {
[string match *state=online* [$master info]]
} else {
fail "Replica never came online"
}
assert_equal bar [r get slavekey]
assert_equal foo [r get masterkey]
}
}
}
}
}