From 2c899d72199c027f49cdf317d30e042e42f9c88f Mon Sep 17 00:00:00 2001 From: John Sully Date: Sat, 1 Feb 2020 21:52:17 -0500 Subject: [PATCH] addRef memory model too restrictive Former-commit-id: 249e0fdd363853ab7b489314002bdacd2438fa55 --- src/server.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/server.h b/src/server.h index 75b2419ac..c3a59db8a 100644 --- a/src/server.h +++ b/src/server.h @@ -784,8 +784,8 @@ public: void setrefcount(unsigned ref); unsigned getrefcount(std::memory_order order) const { return (refcount.load(order) & ~(1U << 31)); } - void addref() const { refcount.fetch_add(1, std::memory_order_acq_rel); } - unsigned release() const { return refcount.fetch_sub(1, std::memory_order_acq_rel) & ~(1U << 31); } + void addref() const { refcount.fetch_add(1, std::memory_order_relaxed); } + unsigned release() const { return refcount.fetch_sub(1, std::memory_order_relaxed) & ~(1U << 31); } } robj; static_assert(sizeof(redisObject) == 24, "object size is critical, don't increase");