From 24223ed818ec6e5ef46945793aed2b08f0a4acb3 Mon Sep 17 00:00:00 2001 From: John Sully Date: Wed, 15 Apr 2020 20:52:25 -0400 Subject: [PATCH] Multithreading reliability, force single thread for test relying on internal behavior Former-commit-id: 033761c5f97fc1d1823a031b34467ac1df5588f3 --- tests/integration/aof.tcl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/integration/aof.tcl b/tests/integration/aof.tcl index 6b1b64b85..9b605c266 100644 --- a/tests/integration/aof.tcl +++ b/tests/integration/aof.tcl @@ -258,7 +258,9 @@ tags {"aof"} { } } - start_server {overrides {appendonly {yes} appendfilename {appendonly.aof} appendfsync always}} { + # Because of how this test works its inherently unreliable with multithreading, so force threads 1 + # No real client should rely on this undocumented behavior + start_server {overrides {appendonly {yes} appendfilename {appendonly.aof} appendfsync always server-threads 1}} { test {AOF fsync always barrier issue} { set rd [redis_deferring_client] # Set a sleep when aof is flushed, so that we have a chance to look