Clarify what is happening in PR #7320.
This commit is contained in:
parent
b7bb6a8ad9
commit
1bf75eaca7
@ -2537,7 +2537,11 @@ void replicationUnsetMaster(void) {
|
|||||||
/* When a slave is turned into a master, the current replication ID
|
/* When a slave is turned into a master, the current replication ID
|
||||||
* (that was inherited from the master at synchronization time) is
|
* (that was inherited from the master at synchronization time) is
|
||||||
* used as secondary ID up to the current offset, and a new replication
|
* used as secondary ID up to the current offset, and a new replication
|
||||||
* ID is created to continue with a new replication history. */
|
* ID is created to continue with a new replication history.
|
||||||
|
*
|
||||||
|
* NOTE: this function MUST be called after we call
|
||||||
|
* freeClient(server.master), since there we adjust the replication
|
||||||
|
* offset trimming the final PINGs. See Github issue #7320. */
|
||||||
shiftReplicationId();
|
shiftReplicationId();
|
||||||
/* Disconnecting all the slaves is required: we need to inform slaves
|
/* Disconnecting all the slaves is required: we need to inform slaves
|
||||||
* of the replication ID change (see shiftReplicationId() call). However
|
* of the replication ID change (see shiftReplicationId() call). However
|
||||||
|
Loading…
x
Reference in New Issue
Block a user