From 1b56a873d57640f07fc062faf00d0fecf7e8cb0a Mon Sep 17 00:00:00 2001 From: antirez Date: Sun, 29 Dec 2019 15:40:40 +0100 Subject: [PATCH] Inline protocol: handle empty strings well. This bug is from the first version of Redis. Probably the problem here is that before we used an SDS split function that created empty strings for additional spaces, like in "SET foo bar". AFAIK later we replaced it with the curretn sdssplitarg() API that has no such a problem. As a result, we introduced a bug, where it is no longer possible to do something like: SET foo "" Using the inline protocol. Now it is fixed. --- src/networking.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/networking.c b/src/networking.c index 37f8fa9b7..dac45751d 100644 --- a/src/networking.c +++ b/src/networking.c @@ -1453,12 +1453,8 @@ int processInlineBuffer(client *c) { /* Create redis objects for all arguments. */ for (c->argc = 0, j = 0; j < argc; j++) { - if (sdslen(argv[j])) { - c->argv[c->argc] = createObject(OBJ_STRING,argv[j]); - c->argc++; - } else { - sdsfree(argv[j]); - } + c->argv[c->argc] = createObject(OBJ_STRING,argv[j]); + c->argc++; } zfree(argv); return C_OK;