From 18ff8cd1fbe0d4c4bc6d090ef58a513ecb9767da Mon Sep 17 00:00:00 2001 From: Pavlo Yatsukhnenko Date: Sun, 28 Feb 2021 15:28:09 +0200 Subject: [PATCH] Fix div by 0 in redis-cli cluster creation (#8553) This could happen on an invalid use, when trying to create a cluster with a single node and provide it's address 3 time to satisfy redis-cli requirements. --- src/redis-cli.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/redis-cli.c b/src/redis-cli.c index 3930a2d8e..63d31f79a 100644 --- a/src/redis-cli.c +++ b/src/redis-cli.c @@ -2972,7 +2972,7 @@ static void clusterManagerOptimizeAntiAffinity(clusterManagerNodeArray *ipnodes, ip_count, &offenders, &offending_len); - if (score == 0) break; // Optimal anti affinity reached + if (score == 0 || offending_len == 0) break; // Optimal anti affinity reached /* We'll try to randomly swap a slave's assigned master causing * an affinity problem with another random slave, to see if we * can improve the affinity. */