do not add save parameter during config rewrite in sentinel mode (#7945)

Previous code would have added default redis save parameters
to the config file on rewrite, which would have been silently ignored
when the config file is loaded.

The new code avoids adding this, and also actively removes these lines
If added by a previous config rewrite.
This commit is contained in:
Wen Hui 2020-10-22 12:47:32 -04:00 committed by GitHub
parent 556acefe75
commit 0f370f9b66
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -1335,6 +1335,12 @@ void rewriteConfigSaveOption(struct rewriteConfigState *state) {
int j;
sds line;
/* In Sentinel mode we don't need to rewrite the save parameters */
if (server.sentinel_mode) {
rewriteConfigMarkAsProcessed(state,"save");
return;
}
/* Note that if there are no save parameters at all, all the current
* config line with "save" will be detected as orphaned and deleted,
* resulting into no RDB persistence as expected. */