gvsafronov/futriix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

avoid using sendfile if tls-replication is enabled

Browse Source 
this obviously broke the tests, but went unnoticed so far since tls
wasn't often tested.
This commit is contained in:
Oran Agra 2020-05-26 13:50:59 +03:00 committed by antirez
parent fee0c76304
commit 0705a29959
1 changed files with 36 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/replication.c
View File

@ -1035,8 +1035,12 @@ void sendBulkToSlave(connection *conn) {
}
}
/* If the preamble was already transferred, send the RDB bulk data. */
/* If the preamble was already transferred, send the RDB bulk data.
* try to use sendfile system call if supported, unless tls is enabled.
* fallback to normal read+write otherwise. */
nwritten = 0;
#if HAVE_SENDFILE
if (!server.tls_replication) {
if ((nwritten = redis_sendfile(conn->fd,slave->repldbfd,
slave->repldboff,PROTO_IOBUF_LEN)) == -1)
{
@ -1047,7 +1051,9 @@ void sendBulkToSlave(connection *conn) {
}
return;
}
#else
}
#endif
if (!nwritten) {
ssize_t buflen;
char buf[PROTO_IOBUF_LEN];
@ -1067,7 +1073,8 @@ void sendBulkToSlave(connection *conn) {
}
return;
}
#endif
}
slave->repldboff += nwritten;
server.stat_net_output_bytes += nwritten;
if (slave->repldboff == slave->repldbsize) {