From 000ae23df42d13c99391a3baf77f2e729e69257a Mon Sep 17 00:00:00 2001 From: Oran Agra Date: Sun, 17 Sep 2017 07:22:16 +0300 Subject: [PATCH] Flush append only buffers before existing. when SHUTDOWN command is recived it is possible that some of the recent command were not yet flushed from the AOF buffer, and the server experiences data loss at shutdown. --- src/server.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/server.c b/src/server.c index ef05f055d..312b95048 100644 --- a/src/server.c +++ b/src/server.c @@ -2536,8 +2536,9 @@ int prepareForShutdown(int flags) { "There is a child rewriting the AOF. Killing it!"); kill(server.aof_child_pid,SIGUSR1); } - /* Append only file: fsync() the AOF and exit */ + /* Append only file: flush buffers and fsync() the AOF at exit */ serverLog(LL_NOTICE,"Calling fsync() on the AOF file."); + flushAppendOnlyFile(1); aof_fsync(server.aof_fd); }